Opened 2 years ago

Last modified 16 months ago

#52514 new update

openconnect-gui @1.3: update to 1.5.2

Reported by: l2dy (Zero King) Owned by: bket
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: horar (Ľubomír Carik)
Port: openconnect-gui

Description


Attachments (2)

openconnect-gui.diff (18.5 KB) - added by bket 2 years ago.
main.log (179.9 KB) - added by mf2k (Frank Schima) 2 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 2 years ago by larryv (Lawrence Velázquez)

Cc: bjorn.ketelaars@… removed
Owner: changed from macports-tickets@… to bjorn.ketelaars@…

comment:2 Changed 2 years ago by bket

I have a diff for bringing openconnect-gui to 1.4.1, however I'm not sure if it is wise to commit it (yet). Two reasons:

There is an issue with one of the dependencies (openconnect). Openconnect-gui 1.4.1. does not build because of this issue. I already reported this upstream and a fix is available [0]. As this fix will be available in a soon to be released update I prefer waiting with updating the portfile for this dependency. However, should you want to experiment I have a diff for net/openconnect/Portfile.

Openconnect-gui 1.4.1. does not support OSX and requires quite a bit of patching. Fortunate upstream did all the work and has a feature branch with the required bits and pieces [1]. I prefer full support over patching in support. What do you think?

I attached a patch for updating 1.3 to 1.4.1. I'm using it on El Capitan. It would be really helpful if I get feedback on the above and on the patch.

[0] http://git.infradead.org/users/dwmw2/openconnect.git/commit/7f5fee6fd53d3ba216d9ef90930041e1dc828914

[1] https://github.com/openconnect/openconnect-gui/tree/feature/macos

Changed 2 years ago by bket

Attachment: openconnect-gui.diff added

comment:3 Changed 2 years ago by l2dy (Zero King)

I prefer full support too.

comment:4 Changed 2 years ago by mf2k (Frank Schima)

This does not build for me. Log attached.

:info:configure CMake Error at CMake/Modules/FindOpenConnect.cmake:54 (message):
:info:configure   Could NOT find OpenConnect, check FindPkgConfig output above!

Changed 2 years ago by mf2k (Frank Schima)

Attachment: main.log added

comment:5 Changed 2 years ago by mf2k (Frank Schima)

$ port installed openconnect
The following ports are currently installed:
  openconnect @7.07_1+gnutls (active)

comment:6 Changed 2 years ago by bket

As stated in my previous message: "There is an issue with one of the dependencies (openconnect)". It seems that you found it as well. The issue has been fixed upstream.
I'm not sure if it makes sense to backport the fix as the only port depending on openconnect is openconnect-gui. In the mean time openconnect works as it should. Also, openconnect-gui 1.3 does not suffer from this issue. In other words: there is no problem.

I'm also not sure about updating openconnect-gui to 1.4.1 as OSX support is currently a 'feature'. As stated I'm able to get it to build and working on El Capitan using the included diff. If I'm not mistaken OSX support for openconnect-gui is planned for 1.5.0.

To summarise - Should one be interested in openconnect-gui 1.4.1. one should:

1.) fix net/openconnect by backporting a fix from upstream or applying a quick and dirt hack http://sprunge.us/aKXG
2.) apply the monster diff included in this ticket.

I'm offering this as a solution to whomever is interested. Please note that I'm not proposing a port update.

comment:7 Changed 16 months ago by l2dy (Zero King)

Summary: openconnect-gui @1.3: update to 1.4.1openconnect-gui @1.3: update to 1.5.2

comment:8 Changed 16 months ago by horar (Ľubomír Carik)

Cc: horar added
Note: See TracTickets for help on using tickets.