Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#52689 closed defect (fixed)

Attica fails to build - missing files from ECM

Reported by: Polyergic (Shad Sterling) Owned by: NicosPavlov
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: NicosPavlov, RJVB (René Bertin), mkae (Marko Käning)
Port: attica

Description

Attica @0.4.2_1+docs fails in configure with an error message about missing files from ECM:

:info:configure CMake Error at CMakeLists.txt:10 (find_package):
:info:configure   Could not find a package configuration file provided by "ECM" (requested
:info:configure   version 0.0.6) with any of the following names:
:info:configure 
:info:configure     ECMConfig.cmake
:info:configure     ecm-config.cmake
:info:configure 
:info:configure   Add the installation prefix of "ECM" to CMAKE_PREFIX_PATH or set "ECM_DIR"
:info:configure   to a directory containing one of the above files.  If "ECM" provides a
:info:configure   separate development package or SDK, be sure it has been installed.

Is this an unclaimed dependency? It doesn't seem likely to be any of the ports found by port search \*ecm\*

Attachments (4)

main.log (15.4 KB) - added by Polyergic (Shad Sterling) 4 years ago.
CMakeOutput.log (33.8 KB) - added by Polyergic (Shad Sterling) 4 years ago.
attica_Portfile.diff (1.3 KB) - added by mkae (Marko Käning) 4 years ago.
patch-includedir.diff (1.0 KB) - added by mkae (Marko Käning) 4 years ago.

Download all attachments as: .zip

Change History (29)

Changed 4 years ago by Polyergic (Shad Sterling)

Attachment: main.log added

Changed 4 years ago by Polyergic (Shad Sterling)

Attachment: CMakeOutput.log added

comment:1 Changed 4 years ago by mkae (Marko Käning)

Cc: rjvbertin@… mk@… added
Version: 2.3.4

comment:2 Changed 4 years ago by mkae (Marko Käning)

Cc: mkae added; mk@… removed

comment:3 Changed 4 years ago by mkae (Marko Käning)

Cc: RJVB added; rjvbertin@… removed

comment:4 Changed 4 years ago by mkae (Marko Käning)

@Polyergic, you are using stock port attica and no local MacPorts source?

Your MacPorts installation has been selfupdated recently?

Last edited 4 years ago by mkae (Marko Käning) (previous) (diff)

comment:5 Changed 4 years ago by mkae (Marko Käning)

Summary: Attica fails to build - mising files from ECMAttica fails to build - missing files from ECM

comment:6 Changed 4 years ago by RJVB (René Bertin)

This is simply a result of building (stock) attica with Qt5 installed and where cmake finds it.

For building attica for Qt4/KDE4 you need at least to add -DQT4_BUILD=ON to the configure.args .

The port from my macstrop repo contains the necessary modifications including some for forward compatibility with the upcoming KF5 ports (and a now redundant -qt5 subport, I see).

Nicos should be the ticket owner, btw.

comment:7 Changed 4 years ago by mkae (Marko Käning)

Owner: changed from macports-tickets@… to nicos@…
Status: newassigned

Thanks, René!

comment:8 Changed 4 years ago by Polyergic (Shad Sterling)

@mkae, no local source, selfupdated a few hours before. I did not request attica, it was brought in as a dependency of kdelibs4 and kde4-runtime. Anything I can do to make it work now?

comment:9 Changed 4 years ago by RJVB (René Bertin)

The easiest way to get it to build while we find a better solution is to deactivate your qt5 port(s) for the duration of the build. Untested, but I think it should work.

comment:10 Changed 4 years ago by Polyergic (Shad Sterling)

It wasn't enough to deactivate qt5, I had to port -p deactivate \*qt5\*, but now attica is installed & activated. Thanks!

comment:11 Changed 4 years ago by mkae (Marko Käning)

Yes, that's what René meant with "qt5 port(s)". Nice that it worked, but it is only a workaround and needs a proper fix.

Changed 4 years ago by mkae (Marko Käning)

Attachment: attica_Portfile.diff added

Changed 4 years ago by mkae (Marko Käning)

Attachment: patch-includedir.diff added

comment:12 Changed 4 years ago by NicosPavlov

Resolution: fixed
Status: assignedclosed

In 00a95b1c/macports-ports:

Attica: Ensure to build with Qt4, even if qt5 is installed (fixes #52689)

comment:13 Changed 4 years ago by mkae (Marko Käning)

Hi @NicosPavlov, is there a reason why you've ignored the two patches which make Attica work with a qt5 co-installation?

Last edited 4 years ago by mkae (Marko Käning) (previous) (diff)

comment:14 Changed 4 years ago by mkae (Marko Käning)

@RJVB, why did you remove phonon in your patch?

comment:15 Changed 4 years ago by RJVB (René Bertin)

Phonon is a dependency that's added by default by the KDE4 1.1 PG because it's needed by most KDE4 software. Not so for attica. I suppose I noticed this by looking at CMake's output, most KDE projects have it print a summary at the end. That includes a list of the unused variables specified on the command line.

comment:16 in reply to:  13 Changed 4 years ago by RJVB (René Bertin)

Replying to mkae:

Hi @NicosPavlov, is there a reason why you've ignored the two patches which make Attica work with a qt5 co-installation?

You mean with a *KF5* co-installation?

comment:17 Changed 4 years ago by mkae (Marko Käning)

Yes, of course.

comment:18 in reply to:  15 Changed 4 years ago by mkae (Marko Käning)

Replying to RJVB:

... because it's needed by most KDE4 software. Not so for attica.

Oh, I see. Now I remember that you mentioned that a while ago - and I forgot about it in the meantime.

comment:19 Changed 4 years ago by NicosPavlov

The patch was doing several things, several of them not related to the issue at hand, so I focused on the part directly related to that ticket. It was also removing the kde4 portgroup and moving headers, which is not related to that ticket, and linked to a more global move of other ports.

comment:20 Changed 4 years ago by mkae (Marko Käning)

OK, so, I understand you suggest to file a new ticket or create a PR for the residual bits from those patches?

comment:21 Changed 4 years ago by RJVB (René Bertin)

Come to think of it, attica/Qt4 does indeed not depend on KDE4, but I did NOT remove the KDE4 PortGroup, did I?!

comment:22 Changed 4 years ago by mkae (Marko Käning)

Well, according to the portfile diff you didn't.

I believe that the changes in the include dirs are actually quite important to include, no!?

comment:23 in reply to:  20 Changed 4 years ago by NicosPavlov

Replying to mkae:

OK, so, I understand you suggest to file a new ticket or create a PR for the residual bits from those patches?

No, I think it is plentifully covered by other tickets such as #49924, #49595, #49109. I guess that's enough already.

comment:24 Changed 4 years ago by mkae (Marko Käning)

OK, cool to see that you have a nice overview of these related tickets. So we can leave this closed then and address the residual bits over there, especially in #49924. Thanks for checking, @NicosPavlov!

comment:25 in reply to:  22 Changed 4 years ago by RJVB (René Bertin)

Replying to mkae:

I believe that the changes in the include dirs are actually quite important to include, no!?

Indeed - but not as long as there is no kf5-attica port and if you don't mind coming back and make yet more adjustments. Attica doesn't depend on KDE4 and thus also doesn't inherit a specific KDE4 header install location, which is why that has to be configured explicitly in this port. I saw that as a reason to include the changes to prepare the port for KF5 in one "fell" swoop, but who am I...

Note: See TracTickets for help on using tickets.