apngasm 2.9.0

[japanesecake (mmallet)]

Hello,

Here is a port for ​APNG Assembler

Any comment is welcome.

[japanesecake (mmallet)]

I removed the $Id tag for subversion

[raimue (Rainer Müller)]

This Portfile just copies a single binary. Is there really no make install target available?

The license should be specified as license zlib, as only that is known to our ​checks.

[japanesecake (mmallet)]

Unfortunately not, there is no install target :/ only "apngasm" and "clean" targets exist (+ some compilation specific targets)

Ok, I will fix the license.

[japanesecake (mmallet)]

Portfile updated

[raimue (Rainer Müller)]

I have some further comments after testing a build with this Portfile. It is missing a dependency on libpng.

@@ -17,6 +17,8 @@
 checksums           rmd160  c4ee4209734a4c3730f6273fc596d5236b6f0c8c \
                     sha256  5dfd34c9a560da81f91d37b891e23761c74659fe36e04ab2a46696562a9ed876

+depends_lib         port:libpng
+
 use_configure       no

 use_zip             yes

The Makefile is calling gcc, see UsingTheRightCompiler. Furthermore, it uses gcc but manually links with libstdc++. This is not a valid combination for clang with libc++. The port should be using ${configure.cxx} and the -lstdc++ argument needs to be removed. Either pass CC= with the correct value, or patch the Makefile to use CXX as a patch is required anyway to remove the -lstdc++ argument.

[japanesecake (mmallet)]

I saw that the libpng source code was in the apngasm-2.9-src archive but did not check whether it was actually used. I will fix it as well aw the compiler options. I will also fix the apngdis Portfile.

Thank you for your review.

[mf2k (Frank Schima)]

Another comment:

• In general, we do not set distfiles directly, it is best practice to simply set ${distname} since you are already have the use_zip line.