VLC fails to build its +qt5 variant

[mkae (Marko Käning)]

VLC alone builds fine on all buildbots, but the qt5 variant seems to have trouble, at least on El Capitan (being the only system tested this on now):

:info:build mv -f .deps/libqt4_plugin_la-actions_manager.Tpo .deps/libqt4_plugin_la-actions_manager.Plo
:info:build ../../../doltlibtool  --tag=CXX   --mode=compile /usr/bin/clang++ -DHAVE_CONFIG_H -I. -I../../..  -DMODULE_STRING=\"$(p="libqt4_plugin_la-recents.    lo"; p="${p##*/}"; p="${p#lib}"; p="${p%_plugin*}"; p="${p%.lo}"; echo "$p")\" -D__PLUGIN__  -I../../../include -I../../../include -I/opt/local/include -         D__unix__=1 -I/opt/local/lib/live/liveMedia/include -I/opt/local/var/macports/build/_Users_marko_WC_GIT_MP_mkae-macports-ports_multimedia_VLC/VLC/work/vlc-2.2.4/ contrib/include  -I/opt/local/libexec/qt5/include/QtWidgets -I/opt/local/libexec/qt5/include -I/opt/local/libexec/qt5/include/QtGui -I/opt/local/libexec/qt5/     include -I/opt/local/libexec/qt5/include/QtCore -I/opt/local/libexec/qt5/include  -pipe -Os -arch x86_64 -stdlib=libc++ -D_INTL_REDIRECT_MACROS -I/opt/local/var/ macports/build/_Users_marko_WC_GIT_MP_mkae-macports-ports_multimedia_VLC/VLC/work/vlc-2.2.4/contrib/include -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wvolatile-register-var -fvisibility=hidden -O3 -ffast-math -funroll-loops -fomit-frame-pointer -MT libqt4_plugin_la-recents.lo -MD -MP -MF .deps/libqt4_plugin_la-recents.Tpo -c -o libqt4_plugin_la-recents.lo `test -f 'recents.cpp' || echo './'`recents.cpp
:info:build 1 warning generated.
:info:build mv -f .deps/libqt4_plugin_la-extensions_manager.Tpo .deps/libqt4_plugin_la-extensions_manager.Plo
:info:build 2 warnings generated.
:info:build mv -f .deps/libqt4_plugin_la-dialogs_provider.Tpo .deps/libqt4_plugin_la-dialogs_provider.Plo
:info:build 4 warnings generated.
:info:build make[7]: *** No rule to make target `util/searchlineedit_mac.mm', needed by `util/libqt4_plugin_la-searchlineedit_mac.lo'.  Stop.
:info:build make[7]: *** Waiting for unfinished jobs....
:info:build mv -f .deps/libqt4_plugin_la-menus.Tpo .deps/libqt4_plugin_la-menus.Plo
:info:build In file included from recents.cpp:27:
:info:build In file included from ./dialogs_provider.hpp:29:
:info:build ../../../config.h:796:9: warning: 'static_assert' macro redefined [-Wmacro-redefined]
:info:build #define static_assert _Static_assert
:info:build         ^
:info:build /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/__config:596:9: note: previous definition is here
:info:build #define static_assert(__b, __m) \
:info:build         ^
:info:build 1 warning generated.
:info:build mv -f .deps/libqt4_plugin_la-recents.Tpo .deps/libqt4_plugin_la-recents.Plo
:info:build make[7]: Leaving directory `/opt/local/var/macports/build/_Users_marko_WC_GIT_MP_mkae-macports-ports_multimedia_VLC/VLC/work/vlc-2.2.4/modules/gui/   qt4'
:info:build make[6]: *** [all] Error 2
:info:build make[6]: Leaving directory `/opt/local/var/macports/build/_Users_marko_WC_GIT_MP_mkae-macports-ports_multimedia_VLC/VLC/work/vlc-2.2.4/modules/gui/   qt4'
:info:build make[5]: *** [all-recursive] Error 1
:info:build make[5]: Leaving directory `/opt/local/var/macports/build/_Users_marko_WC_GIT_MP_mkae-macports-ports_multimedia_VLC/VLC/work/vlc-2.2.4/modules/gui'
:info:build make[4]: *** [all] Error 2
:info:build make[4]: Leaving directory `/opt/local/var/macports/build/_Users_marko_WC_GIT_MP_mkae-macports-ports_multimedia_VLC/VLC/work/vlc-2.2.4/modules/gui'
:info:build make[3]: *** [all-recursive] Error 1
:info:build make[3]: Leaving directory `/opt/local/var/macports/build/_Users_marko_WC_GIT_MP_mkae-macports-ports_multimedia_VLC/VLC/work/vlc-2.2.4/modules'
:info:build make[2]: *** [all] Error 2
:info:build make[2]: Leaving directory `/opt/local/var/macports/build/_Users_marko_WC_GIT_MP_mkae-macports-ports_multimedia_VLC/VLC/work/vlc-2.2.4/modules'
:info:build make[1]: *** [all-recursive] Error 1
:info:build make[1]: Leaving directory `/opt/local/var/macports/build/_Users_marko_WC_GIT_MP_mkae-macports-ports_multimedia_VLC/VLC/work/vlc-2.2.4'
:info:build make: *** [all] Error 2
:info:build make: Leaving directory `/opt/local/var/macports/build/_Users_marko_WC_GIT_MP_mkae-macports-ports_multimedia_VLC/VLC/work/vlc-2.2.4'
:info:build Command failed:  cd "/opt/local/var/macports/build/_Users_marko_WC_GIT_MP_mkae-macports-ports_multimedia_VLC/VLC/work/vlc-2.2.4" && /usr/bin/make -   j5 -w all DESTDIR=/opt/local/var/macports/build/_Users_marko_WC_GIT_MP_mkae-macports-ports_multimedia_VLC/VLC/work/vlc-2.2.4/dest_ignore V=1
:info:build Exit code: 2
:error:build org.macports.build for port VLC returned: command execution failed

Weird seeing Qt4 stuff being built, although the qt5 variant is wanted.

[RJVB (René Bertin)]

To be honest, I'm not sure why I have preserved the Qt variants. They built at some point, but there's something fundamentally wrong in how they handle the event loop on OS X (IIRC not on the main thread where it has to be).

[mkae (Marko Käning)]

So, perhaps it's a good idea to keep some notes in VLC's Portfile hinting that out?!

[RJVB (René Bertin)]

The variant description is clear enough already, don't you think?

   qt4: Build using Qt4 UI. This will use qt4-mac. Experimental and probably dysfunctional
     * conflicts with qt5
   qt5: Build using Qt5 UI. This will use qt5-mac. Experimental and probably dysfunctional
     * conflicts with qt4

Edit: clear enough, and clearly dated too. :)

[mkae (Marko Käning)]

Yes, it indeed is, sorry for not checking before commenting. :)

So, shall we close this issue as "WontFix" for now and let anyone reopen it if there are new suggestions how to tackle this?

[RJVB (René Bertin)]

Fine with me.

In fact, I think we could remove the Qt variants. IIRC they're not supported for Mac by VideoLan, and they have little interest since there's a good native interface. We can also wait and see when VLC 3 is released.