cctools @895_3 fails to build on OS X 10.5

[pkoshevoy (Pavel Koshevoy)]

can't upgrade libvpx because cctools fails to build:

:info:build /usr/bin/gcc-4.2 -Os -std=gnu99 -std=c99 -Os -DLTO_SUPPORT -g -I../../include -Wall -D_MACH_I386_THREAD_STATUS_FPSTATE_LEGACY_FIELD_NAMES_ -D_ARCHITECTURE_I386_FPU_FPSTATE_LEGACY_FIELD_NAMES_ -I/opt/local/include -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_cctools/cctools/work/cctools-895/../ld64-274.1/src/abstraction -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_cctools/cctools/work/cctools-895/../ld64-274.1/src/other -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_cctools/cctools/work/cctools-895/include -arch i386 -I/opt/local/libexec/llvm-3.3/include  -DNDEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -O3  -g -fno-common   -c \
:info:build 		-I/opt/local/include \
:info:build 		-I/opt/local/include \
:info:build 		-o ./lto.o ../lto.c
:info:build ../lto.c:21: error: expected declaration specifiers or ‘...’ before ‘*’ token
:info:build ../lto.c:21: warning: type defaults to ‘int’ in declaration of ‘lto_bool_t’
:info:build ../lto.c:21: error: ‘lto_bool_t’ declared as function returning a function
:info:build ../lto.c:21: error: function ‘lto_bool_t’ is initialized like a variable
:info:build ../lto.c: In function ‘is_llvm_bitcode_from_memory’:
:info:build ../lto.c:137: error: ‘lto_is_object’ undeclared (first use in this function)
:info:build ../lto.c:137: error: (Each undeclared identifier is reported only once
:info:build ../lto.c:137: error: for each function it appears in.)
:info:build ../lto.c:164: warning: implicit declaration of function ‘lto_is_object’
:info:build make[2]: *** [lto.o] Error 1
:info:build make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_cctools/cctools/work/cctools-895/libstuff/dynamic_obj'
:info:build make[1]: *** [dynamic] Error 2
:info:build make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_cctools/cctools/work/cctools-895/libstuff'
:info:build make: *** [all] Error 1
:info:build make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_cctools/cctools/work/cctools-895'
:info:build Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_cctools/cctools/work/cctools-895" && /usr/bin/make -w all RC_OS="macos" RC_ProjectSourceVersion=895 USE_DEPENDENCY_FILE=NO BUILD_DYLIBS=NO CC="/usr/bin/gcc-4.2 -Os -std=gnu99" CXX="/usr/bin/g++-4.2 -Os" CXXLIB="" TRIE=-DTRIE_SUPPORT RC_ARCHS="i386" SDK="-I/opt/local/include -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_cctools/cctools/work/cctools-895/../ld64-274.1/src/abstraction -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_cctools/cctools/work/cctools-895/../ld64-274.1/src/other -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_cctools/cctools/work/cctools-895/include" LTO=-DLTO_SUPPORT RC_CFLAGS="-arch i386 `llvm-config-mp-3.3 --cflags`" LLVM_MC="llvm-mc-mp-3.3" 
:info:build Exit code: 2
:error:build org.macports.build for port cctools returned: command execution failed
:debug:build Error code: CHILDSTATUS 28743 2
:debug:build Backtrace: command execution failed
    while executing
"system -nice 0 $fullcmdstring"
    ("eval" body line 1)
    invoked from within
"eval system $notty $nice \$fullcmdstring"
    invoked from within
"command_exec build"
    (procedure "portbuild::build_main" line 8)
    invoked from within
"portbuild::build_main org.macports.build"
    ("eval" body line 1)
    invoked from within
"eval $procedure $targetname"
:info:build Warning: targets not executed for cctools: org.macports.activate org.macports.build org.macports.destroot org.macports.install
:notice:build Please see the log file for port cctools for details:
    /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_cctools/cctools/main.log

[pkoshevoy (Pavel Koshevoy)]

main.log

[jeremyhu (Jeremy Huddleston Sequoia)]

 $ ls -l /opt/local/var/macports/software/cctools/
total 3832
-rw-r--r-- 1 root admin 3922865 Dec 20 21:45 cctools-895_3+llvm39+universal.darwin_9.i386-x86_64.tbz2

I suspect the issue is for +llvm33

[kencu (Ken)]

for a data point

$ port -v installed | grep cctools
  cctools @886_6+llvm33 platform='darwin 9' archs='i386'
  cctools @886_6+llvm38+universal-llvm33-llvm34 platform='darwin 9' archs='i386 x86_64'
  cctools @895_3+llvm39+universal-llvm33-llvm34 (active) platform='darwin 9' archs='i386 ppc x86_64'

[jeremyhu (Jeremy Huddleston Sequoia)]

In 373d97e8/macports-ports:

cctools: Remove +llvm33 variant

This removes support for LTO by default on Leopard. Leopard users can
reinstall with +llvm34 (or higher) to get back LTO support.

Fixes #53182

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@…>