Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#53350 closed defect (fixed)

fontconfig: support mpgk/mdmg packaging

Reported by: ctreleaven (Craig Treleaven) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: mkae (Marko Käning)
Port: fontconfig

Description

Patch adds a postinstall script, etc, that mimics the existing post-activate step (which initializes or updates the font cache).

fontconfig is used by a variety of packages including libass, libbluray, qt5-qtbase, qt5-qtwebkit among others. Thus this script will propogate to any installer incorporating any of these packages.

Tested by creating and installing an mpkg of fontconfig. Installer log attached showing successful completion.

Attachments (2)

patch_port_fontconfig_support_packaging.diff (1.2 KB) - added by ctreleaven (Craig Treleaven) 7 years ago.
Installer Log 18-Jan-2017_1.txt (26.3 KB) - added by ctreleaven (Craig Treleaven) 7 years ago.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by ctreleaven (Craig Treleaven)

Changed 7 years ago by ctreleaven (Craig Treleaven)

comment:1 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)

Ok, except:

  • use xinstall instead of file copy and thus avoid the need to separately call file attributes
  • use 4 spaces per indent
  • why change the long description?

comment:2 Changed 7 years ago by mkae (Marko Käning)

Cc: mkae added

comment:3 Changed 7 years ago by ctreleaven (Craig Treleaven)

Will do on the first two points.

The long_description shows on the first installer splash screen. I've found it useful to confirm the prefix that the payload is going to be installed into. One of the most common questions I get about my installers is: "where did everything go?".

I'll update the patch shortly. Do you want to a) apply the patch, b) deal with a pull request or c) let me commit (er, push) the change? ;)

comment:4 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)

I am not dealing with pull requests at this time. Feel free to commit.

comment:5 Changed 7 years ago by ctreleaven (Craig Treleaven)

Resolution: fixed
Status: newclosed
Last edited 7 years ago by ryandesign (Ryan Carsten Schmidt) (previous) (diff)
Note: See TracTickets for help on using tickets.