Opened 7 years ago

#53387 new enhancement

Pextlib/xinstall : don't ignore directory chmod errors silently

Reported by: RJVB (René Bertin) Owned by:
Priority: Normal Milestone:
Component: base Version:
Keywords: haspatch Cc: neverpanic (Clemens Lang)
Port:

Description

As discussed on the ML, Pextlib's InstallCmd() (xinstall callback) ignores errors that occur setting the requested or default permissions. That's probably not a good idea; the attached patch adds error handling that's near-identical to handling fchmod() errors elsewhere in the same file.

I have not removed the patch hunks that add a verbose (-v) mode to xinstall, you can take them as a FYI.

Attachments (1)

patch-xinstall-mkdirchmod-warning.diff​ (3.6 KB) - added by RJVB (René Bertin) 7 years ago.

Download all attachments as: .zip

Change History (1)

Changed 7 years ago by RJVB (René Bertin)

Attachment: patch-xinstall-mkdirchmod-warning.diff​ added
Note: See TracTickets for help on using tickets.