port diagnose fails on symlink

[fracai]

$ sudo port diagnose
…
Checking for file '/opt/local/lib/pkgconfig/texluajit.pc' on disk... [SUCCESS]
Checking for file '/opt/local/libexec/texlive/binaries/a2ping' on disk... [FAILED]
Checking for file '/opt/local/libexec/texlive/binaries/a5toa4' on disk... [FAILED]
Checking for file '/opt/local/libexec/texlive/binaries/adhocfilelist' on disk... [FAILED]
Checking for file '/opt/local/libexec/texlive/binaries/afm2afm' on disk... [FAILED]
Checking for file '/opt/local/libexec/texlive/binaries/afm2pl' on disk... [SUCCESS]
…

All of the failed lines represent symlinks to other files that do exist on disk.

I also note that these failures aren't actually reported unless I redirect the output and without that redirect, there's no indication that anything has failed. I'm not sure if that indicates the file is actually detected (unlikely) or if that's a different issue where the failures aren't reported.

[mkae (Marko Käning)]

(I am not sure whether assigning this to admin@mpo is actually necessary, but lately all new tickets have an empty owned by field...)

[jmroot (Joshua Root)]

No, assigning to admin@ is only correct for tickets that need the attention of a sysadmin (so usually server/hosting component).

[jmroot (Joshua Root)]

In 103d6f6/macports-base:

Port diagnose file check fix

Don't report failure before checking whether a port's apparently
missing file is actually a link.

Fixes: #53490