gdal: update to 2.2.1

[petrrr]

Simple requesting as dependency for py-gdal.

[Veence (Vincent)]

Sorry I'm a bit snowed under today, but will do that at the earliest opportunity.

[Veence (Vincent)]

Done in dd76b5bf0e

[gnw3]

First, no need to apologize for the delay -- we are grateful when people like you find time to maintain ports. It is users like me who should apologize for still using legacy systems that require Snow Leopard and making your work more difficult.

gdal @2.2.1 +expat+gcc6+hdf4+hdf5+netcdf+openmpi fails to install on SnowLeopard:

DEBUG: MACOSX_DEPLOYMENT_TARGET='10.6'
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_github.com_macports_macports-ports_gis_gdal/gdal/work/gdal-2.2.1" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/github.com/macports/macports-ports/gis/gdal/files/patch-configure-isnan.diff'
DEBUG: system:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_github.com_macports_macports-ports_gis_gdal/gdal/work/gdal-2.2.1" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/github.com/macports/macports-ports/gis/gdal/files/patch-configure-isnan.diff'
patching file configure
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file configure.rej
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_github.com_macports_macports-ports_gis_gdal/gdal/work/gdal-2.2.1" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/github.com/macports/macports-ports/gis/gdal/files/patch-configure-isnan.diff'
Exit code: 1
Error: Failed to patch gdal: command execution failed

This is one of three patches for systems that lack C++11 support. A comment says the patches were backported from master, so I guess they are already in gdal-2.2.1. After removing the patches, configure succeeds, but the build fails with:

netcdfdataset.cpp: In static member function 'static double netCDFDataset::rint(
double)':
netcdfdataset.cpp:4588:12: error: 'round' is not a member of 'std'
     return std::round(dfX);
            ^~~

This problem was also in gdal-2.2.0. In netcdfdataset.cpp the above line is from the following block:

#ifdef HAVE_CXX11
double netCDFDataset::rint( double dfX )
{
    return std::round(dfX);
}
#else

After editing this file to change HAVE_CXX11 to NOT_HAVE_CXX11. gdal-2.2.1 installed successfully here.

[mf2k (Frank Schima)]

Please do not re-open this ticket. This issue was resolved. You have a different issue and that requires a new ticket.