xorg-server 1.18.4_2: fails to compile on sierra

[EdHarry]

Xorg-Server 1.18.4_2 fails to compile on MacOS 10.12.5 (16F73), Xcode version 8.3.3 (8E3004b)

[EdHarry]

main log

[EdHarry]

This update (1.18.4_2) added a build dependency on mp-clang-3.7, which I believe was the compiler used for the build. This could be the reason for the clash with the current framework?

[EdHarry]

Confirmed the problem is with mp-clang-3.7, sudo port -v install xorg-server configure.compiler=macports-clang-3.9 successfully installs the port.

(I don't know if the problem is the mp-clang-3.7 port in general or just my install.)

[michaellass (Michael Lass)]

It compiles fine using clang 3.9 but you will probably face this issue again: #53910

The fix for clang linked below didn't make it into clang 3.9 as far as I can see. This is why this version is also blacklisted in the Portfile. ​https://bugs.llvm.org/show_bug.cgi?id=30346

Right now I am not sure how xorg-server can be built without this issue using compilers that are readily available in macports.

[eborisch (Eric A. Borisch)]

clang-4.0 worked just fine for me. I have it (but not clang-3.7) installed so it appears to have automatically selected it.

[michaellass (Michael Lass)]

At least on my system, clang-4.0 is not automatically used by macports. I had to adjust the Portfile as follows to automatically choose clang-4.0. Indeed, building the port works fine, and the required patch to fix the runtime issue should be included in clang-4.0 as well.

--- a/x11/xorg-server/Portfile	2017-07-20 17:14:14.000000000 +0200
+++ b/x11/xorg-server/Portfile	2017-07-20 17:14:03.000000000 +0200
@@ -69,7 +69,8 @@
 # https://trac.macports.org/ticket/36055
 # https://llvm.org/bugs/show_bug.cgi?id=30346
 # https://trac.macports.org/ticket/53910
-compiler.blacklist gcc-4.0 macports-clang-3.8 macports-clang-3.9 macports-clang-devel {clang >= 802 < 900}
+compiler.blacklist gcc-4.0 macports-clang-3.7 macports-clang-3.8 macports-clang-3.9 macports-clang-devel {clang >= 802 < 900}
+compiler.fallback macports-clang-4.0
 
 configure.args --with-apple-applications-dir=${applications_dir} \
 	--with-bundle-id-prefix=org.macports \

Leaving out the compiler.fallback line, I just get the message "Warning: All compilers are either blacklisted or unavailable; defaulting to first fallback option" and XCode's clang is used.

[jeremyhu (Jeremy Huddleston Sequoia)]

I thought I blocked clang-3.7 on Sierra because of this:

:info:build /System/Library/Frameworks/Foundation.framework/Headers/NSObject.h:44:12: error: unknown property attribute 'class'
:info:build @property (class, readonly) BOOL supportsSecureCoding;
:info:build            ^

[jeremyhu (Jeremy Huddleston Sequoia)]

I suspect the version of base that you have isn’t picking 4.0. This will be addressed whenever a newer version of base is released, but I’m also cleaning up the list to not include these toolchains on newer macOS versions.

[jeremyhu (Jeremy Huddleston Sequoia)]

In b1b1ea0bc8520ba5bf2faf4dfd0e4b48a2ed2b6f/macports-base:

Remove clang-3.[789] from OS versions with SDKs that require functionality not in those compilers

Fixes #54504

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@…>

[jeremyhu (Jeremy Huddleston Sequoia)]

I’ll get a change into the Portfile to work with shipping versions of base as well.

[raimue (Rainer Müller)]

This fix was released with MacPorts 2.4.2.