Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#54657 closed submission (fixed)

tEXT-iNSERTEr @0.5.4.0

Reported by: lilca Owned by: mf2k (Frank Schima)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: tEXT-iNSERTEr

Description


Attachments (5)

Portfile (1.3 KB) - added by lilca 7 years ago.
Portfile.2 (1.1 KB) - added by lilca 7 years ago.
Portfile.diff (1.9 KB) - added by lilca 7 years ago.
tEXT-iNSERTEr-3ed6f297016a231fb41b5bd5731db00a0d624e43-master.diff (1.9 KB) - added by lilca 7 years ago.
Portfile.3 (1.1 KB) - added by lilca 7 years ago.

Download all attachments as: .zip

Change History (17)

Changed 7 years ago by lilca

Attachment: Portfile added

comment:1 Changed 7 years ago by raimue (Rainer Müller)

Does this really require a special download just for MacPorts? If not, you could use the github port group to simplify this Portfile.

It seems like this fits more into category "textproc" than "devel".

The current license statement is invalid, it should be just "BSD".

destroot.violate_mtree no is the default and does not need to be set.

The upstream Makefile is calls gcc without any variable allowing to change the compiler. This needs to be patched to honor the compiler selection inside MacPorts; see UsingTheRightCompiler.

comment:2 Changed 7 years ago by mf2k (Frank Schima)

Summary: tir @0.5.4.0: a new port request.tir @0.5.4.0

comment:3 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)

Also, the maintainers line is invalid. You probably meant @lilca instead of just lilca.

comment:4 Changed 7 years ago by lilca

For simplify with github group, I want to change this port name form tir to tEXT-iNSERTEr.
Shoud I create a new ticket?

Changed 7 years ago by lilca

Attachment: Portfile.2 added

Changed 7 years ago by lilca

Attachment: Portfile.diff added

comment:5 in reply to:  4 Changed 7 years ago by mf2k (Frank Schima)

Port: tEXT-iNSERTEr added; tir removed

Replying to lilca:

For simplify with github group, I want to change this port name form tir to tEXT-iNSERTEr.
Shoud I create a new ticket?

No, we can easily modify this ticket.

FYI, you can still keep the name "tir" and use the GitHub portgroup by setting the name field after the github.setup command.

comment:6 Changed 7 years ago by mf2k (Frank Schima)

Summary: tir @0.5.4.0tEXT-iNSERTEr @0.5.4.0

comment:7 Changed 7 years ago by lilca

On this port, I think that tEXT-iNSERTEr is suitable.
Thank you. it was helpful.

comment:8 Changed 7 years ago by mf2k (Frank Schima)

Some more comments:

  • Can openmaintainer be added?
  • I don't see where tEXT-iNSERTEr-3ed6f297016a231fb41b5bd5731db00a0d624e43-master.diff gets used. Are you missing a patchfile line?
  • You are using use_configure no. Does the universal variant work? Usually more work needs to be done in this case. If it does not work, just add universal_variant no.

comment:9 Changed 7 years ago by lilca

I don't see where tEXT-iNSERTEr-3ed6f297016a231fb41b5bd5731db00a0d624e43-master.diff gets used. Are you missing a patchfile line?

I was misunderstanding. Please delete it if it is not necessary.

Changed 7 years ago by lilca

Attachment: Portfile.3 added

comment:10 Changed 7 years ago by mf2k (Frank Schima)

When I built it, it was using libgcc. We prefer that ports build with Apple's compiler (clang for Sierra). Per this wiki page, I added the following to fix it.

build.args-append       CC=${configure.cc} \
                        CXX=${configure.cxx} \
                        CPP=${configure.cpp}

comment:11 Changed 7 years ago by mf2k (Frank Schima)

Owner: set to mf2k
Resolution: fixed
Status: newclosed

comment:12 Changed 7 years ago by lilca

Thank you for comments and addtions.

Note: See TracTickets for help on using tickets.