advancemame: Update to version 3.5

[mf2k (Frank Schima)]

I am attempting to update advancemame to the latest version. But I am stuck on the following configure error:

:debug:configure system:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_github.com_macports_macports-ports_emulators_advancemame/advancemame/work/advancemame-3.5" && ./configure --prefix=/opt/local --mandir=/opt/local/share/man --with-sdl2-prefix=/opt/local --enable-asm=no 
:info:configure configure: error: cannot find install-sh, install.sh, or shtool in "." "./.." "./../.."

Attaching a diff for my non-working Portfile. Fixes welcome.

[mf2k (Frank Schima)]

latest version

[mf2k (Frank Schima)]

Thanks to jmroot for the suggestions, this update gets past configure, but hits a build error:

:info:build srcmess/artwork.c:2307:61: error: incomplete definition of type 'struct png_info_def'
:info:build         if (png.height != original->height || png.width != original->width)
:info:build                                                            ~~~~~~~~^
:info:build /opt/local/include/png.h:484:16: note: forward declaration of 'struct png_info_def'

[kencu (Ken)]

I don't know how old this software is, but this error looks like the errors that were seen when libpng updated to 1.5 and changed it API...

35949

52190

[mf2k (Frank Schima)]

The latest version was released April 6, 2017. So it is not that old.

[ryandesign (Ryan Carsten Schmidt)]

And yet the source file in question, srcmess/artwork.c, has a copyright date of 2006, at which time libpng version 1.2 was current, so the code may need to be updated for later versions of libpng.

Also, because in the pre-configure block you're copying files provided by automake, you need to add a build dependency on automake.

[mf2k (Frank Schima)]

@ryandesign: Thanks for the comments. Exactly, their code needs to be updated for newer libpng. Unless I'm missing something, automake is already there as a build dependency in my patch. use_autoreconf yes brings it in.

[mf2k (Frank Schima)]

Updated at some point. It is at version 3.9 currently.