libftdi1 @1.4: won't compile when libftdi0 is installed

[rufty (Bill Hill)]

Tried to upgrade libftdi1 and got errors "undeclared identifier 'TYPE_230X" on OSX 10.11.6

[rufty (Bill Hill)]

logfile

[mf2k (Frank Schima)]

What is the output of the following?

xcodebuild -version

and

port installed boost

[rufty (Bill Hill)]

$ xcodebuild -version
Xcode 8.2.1
Build version 8C1002
$ port installed boost
The following ports are currently installed:
  boost @1.59.0_3+no_single+no_static+python27 (active)

[mf2k (Frank Schima)]

Remember to use WikiFormatting in your comments.

That all looks good. Hopefully the maintainer can find out the problem.

It builds fine for me on Sierra.

[ryandesign (Ryan Carsten Schmidt)]

The problem is here:

:info:build [ 90%] Building CXX object test/CMakeFiles/test_libftdi1.dir/baudrate.cpp.o
:info:build cd /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_libftdi/libftdi1/work/build/test && /usr/bin/clang++   -I/opt/local/include -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_libftdi/libftdi1/work/libftdi1-1.4/src -I/opt/local/include/libusb-1.0  -Os -DNDEBUG -arch x86_64 -mmacosx-version-min=10.11   -Wall -o CMakeFiles/test_libftdi1.dir/baudrate.cpp.o -c /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_libftdi/libftdi1/work/libftdi1-1.4/test/baudrate.cpp
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_libftdi/libftdi1/work/libftdi1-1.4/test/baudrate.cpp:105:14: error: use of undeclared identifier 'TYPE_230X'; did you mean 'TYPE_232H'?
:info:build         case TYPE_230X:
:info:build              ^~~~~~~~~
:info:build              TYPE_232H
:info:build /opt/local/include/ftdi.h:25:97: note: 'TYPE_232H' declared here

I am able to reproduce this build failure, if the libftdi0 port is installed when trying to build libftdi1. The workaround is to deactivate the libftdi0 port first.

baudrate.cpp contains the line #include <ftdi.h>. The compiler is being told to look for that file first in /opt/local/include. If the file were not found there, it would look in the second location /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_libftdi/libftdi1/work/libftdi1-1.4/src and find it there and everything would be fine. But because libftdi0 is installed, an older incompatible version of ftdi.h is present in /opt/local/include, causing the build failure.

The proper solution is to fix the order of the -I arguments, but I haven't looked at the build system to see how that might be accomplished.

Until then, PortGroup conflicts_build 1.0 and conflicts_build libftdi0 could be added to the Portfile.

[ryandesign (Ryan Carsten Schmidt)]

In c1ddfb6fcbc0b9b63d229206a15ea40c0e56f532/macports-ports:

libftdi1: Prevent build failure when libftdi0 is active

See: #54712

[nerdling (Jeremy Lavergne)]

It looks like the incorrect order only occurs in a test.

One option is to disable tests (-DBUILD_TESTS=FALSE) or editing the INCLUDE_DIRECTORIES() to use AFTER.

[nerdling (Jeremy Lavergne)]

Flipped tests' include order in 9355987a894f1df6ef2b334abaf5d3dffcd6caf9/macports-ports