dovecot2 2.2.32 fails to build on i386 Snow Leopard

[grumpybozo (Bill Cole)]

The error is:

libtool: compile:  /usr/bin/g++-4.2 -DHAVE_CONFIG_H -I. -I../../.. -I../../../src/lib -I../../../src/lib-mail -I../../../src/lib-index -I../../../src/lib-storage -I../../../src/plugins/fts -I../../../src/doveadm -I/opt/local/include/openssl -I/opt/local/include -I/opt/local/include/CLucene/ext -pipe -Os -arch i386 -D__STDC_LIMIT_MACROS -MT lucene-wrapper.lo -MD -MP -MF .deps/lucene-wrapper.Tpo -c lucene-wrapper.cc  -fno-common -DPIC -o .libs/lucene-wrapper.o
    In file included from ../../../src/lib/lib.h:33,
                     from lucene-wrapper.cc:4:
    ../../../src/lib/byteorder.h:94: error: integer constant is too large for ‘long’ type
    ../../../src/lib/byteorder.h:95: error: integer constant is too large for ‘long’ type
    ../../../src/lib/byteorder.h:96: error: integer constant is too large for ‘long’ type
    ../../../src/lib/byteorder.h:97: error: integer constant is too large for ‘long’ type
    make[4]: *** [lucene-wrapper.lo] Error 1

Adding 'LL' to the end of the 16-digit hex literals in byteorder.h that are used to test the structure of 64-bit integers fixes this and avoids any problem which could arise from the compiler using a 32-bit type for those literals that could fit in 32 bites.

[grumpybozo (Bill Cole)]

patch for src/lib/byteorder.h to specify type of 64-bit literals

[grumpybozo (Bill Cole)]

As noted in the upstream pull request, the correct suffix is 'ULL' because the literals are used as masks against a uint64_t argument. Patch file replaced.

[pixilla (Bradley Giesbrecht)]

Do you have a link to an upstream issue/pull request?

[grumpybozo (Bill Cole)]

​https://github.com/dovecot/core/pull/55

[grumpybozo (Bill Cole)]

Fixed upstream. This ticket can be closed