libphonenumber-cpp @8.8.3: should not fetch files in post-extract

[ryandesign (Ryan Carsten Schmidt)]

libphonenumber-cpp should not fetch additional files in post-extract as it does here:

set gtest_version   1.7.0
set gtest_dir       ${workpath}
set gtest_archive   v${gtest_version}.zip
set gtest_srcdir    ${gtest_dir}/gtest-${gtest_version}
set gtest_url       https://github.com/neloe/gtest/archive

post-extract {
    curl fetch ${gtest_url}/${gtest_archive} ${gtest_dir}/${gtest_archive}
    system "/usr/bin/unzip -d ${gtest_dir} ${gtest_dir}/${gtest_archive}"
}

All fetching should happen in the fetch phase. Let MacPorts do it for you by adding the gtest distfile to the distfiles variable.

Switch to a .tar.gz file so that MacPorts can extract it for you too, since the port's main distfile is a .tar.gz file, and also because .tar.gz files are smaller than .zip files.

Shouldn't you be ​getting gtest from the developers directly, rather than from some random person's GitHub repo?

[ryandesign (Ryan Carsten Schmidt)]

Now that GitHub has increased their minimum security requirements, GitHub files cannot be fetched by the curl included with OS X 10.8 or earlier. So please fix this, so that the MacPorts distfiles mirror can be a workaround for that problem.

[ryandesign (Ryan Carsten Schmidt)]

Replying to ryandesign:

Shouldn't you be ​getting gtest from the developers directly, rather than from some random person's GitHub repo?

This part was fixed in [3ea833cb487bdc685c770e526345ea4cb2286c28/macports-ports].

[ryandesign (Ryan Carsten Schmidt)]

The rest was fixed in [00edbf785c339c76cd020d95c2428a828ae38544/macports-ports].