Opened 3 years ago

Closed 3 years ago

#55123 closed defect (wontfix)

wxWidgets-3.0 should export @interface ModalDialogDelegate

Reported by: RJVB (René Bertin) Owned by: mojca (Mojca Miklavec)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: wxWidgets-3.0

Description

As shown by #55115 :

I think WxWidgets should export the ModalDialogDelegate class; doing so should fix the issue in Audacity above.

In $prefix/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0/include/wx-3.0/wx/osx/cocoa/private.h, there should be

#ifdef __LP64__
    WXEXPORT
#endif // 64 bit builds

above the @interface ModalDialogDelegate : NSObject line.

If my reading of nm /opt/local/Library/Frameworks/wxWidgets.framework/Versions/wxWidgets/3.0/lib/libwx_osx_cocoau_core-3.0.dylib is correct, that WXEXPORT macro has the intended effect on the wxNSAppController class which is already being exported.

Could you try on your end if this is indeed the required fix, please?

Change History (4)

comment:1 Changed 3 years ago by Schamschula (Marius Schamschula)

Cc: mojca removed
Owner: set to mojca
Status: newassigned

comment:2 Changed 3 years ago by RJVB (René Bertin)

As you've seen I have found another fix for the original issue - but I'm not certain if it's a fix or a workaround. First thing to do when users report unexpected feature loss would be to revert the Audacity patch and test with a wxWidgets port that's patched to export the ModalDialogDelegate class.

There's very little side-effect to exporting a single class (AFAICT).

comment:3 Changed 3 years ago by mojca (Mojca Miklavec)

I would be very grateful if we could get some feedback from either Audacity and/or wxWidgets upstream developers.

comment:4 Changed 3 years ago by mojca (Mojca Miklavec)

Resolution: wontfix
Status: assignedclosed

A workaround/fix(?) has been implemented in audacity port.

Note: See TracTickets for help on using tickets.