Update protobuf3-cpp to version 3.5.1

[MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)]

Attached is a proposed patch to update protobuf3-cpp to the latest version.

[blair (Blair Zajac)]

In a9a89956680347178bba50e3d3ce87052e832878/macports-ports:

protobuf3-cpp: new upstream 3.5.1 release.

Fixes: #55650

[kencu (Ken)]

Just FYI, protobuf3-cpp also offers a way to build on systems that don't offer thread_local storage:

configure.cppflags-append  -DGOOGLE_PROTOBUF_NO_THREADLOCAL

I've been using this flag for a year or so now to build this on 10.6.8 / libc++ . It also works on a couple of other ports that include protobuf3 internally.

$ port -v installed protobuf3-cpp
The following ports are currently installed:
  protobuf3-cpp @3.5.1_0 (active) platform='darwin 10' archs='x86_64' date='2018-01-06T11:02:57-0800'

$ otool -L /opt/local/lib/libprotobuf.15.dylib
/opt/local/lib/libprotobuf.15.dylib:
	/opt/local/lib/libprotobuf.15.dylib (compatibility version 16.0.0, current version 16.1.0)
	/opt/local/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
	/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 5.0.1)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 125.2.11)
	/usr/lib/libc++abi.dylib (compatibility version 1.0.0, current version 5.0.1)

[blair (Blair Zajac)]

You propose replacing the line

return -code error "incompatible Mac OS X version"

with

configure.cppflags-append  -DGOOGLE_PROTOBUF_NO_THREADLOCAL

?

[kencu (Ken)]

That does work -- it shifts to pthreads instead of thread_local. I'm pondering any downsides to that, but don't see any...

Every system should work. What do you think?

[blair (Blair Zajac)]

In 869f8ffb42c461ecb0b1a74e28fd4eff623321a9/macports-ports:

protobuf3-cpp: support OS/compiler combinations without thread local storage.

Fixes: #55650