Opened 3 years ago

Closed 2 years ago

#55729 closed defect (invalid)

macports brotli clashes with the nginx module ngx_brotli

Reported by: eiked Owned by: raimue (Rainer Müller)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: brotli

Description

the port "brotli" should not install anything in lib or include

This clashes with ngx_brotli see https://trac.nginx.org/nginx/ticket/1465

  • brotli is not yet a well defined lib
  • the libs as intstalled by the brotli port are outdated
  • installing the brotli tool should not install libs or includes in /opt/local
  • a revised version of the brotli port should explicitely remove all artefacts from lib and include

This is not a fault of the brotli port, but it revealed severe bugs elsewhere.

But for the peace of mind, let's fix the macports install of the brotli tool as quick as we can.

Change History (3)

comment:1 Changed 3 years ago by mf2k (Frank Schima)

Owner: set to raimue
Port: brotli added
Status: newassigned

In the future, please fill in the Port field and Cc the port maintainers (port info --maintainers brotli).

comment:2 Changed 3 years ago by raimue (Rainer Müller)

I am not sure I can follow your argument. Although the brotli command line tool itself is statically linked (in my opinion a bad decision by upstream), the libraries are an essential part of this port. They are already in use by dependents, so we cannot remove them.

What makes you think the libraries are outdated? brotli 1.0.2 is the latest release.

As I see it, this is a problem with the build system in ngx_brotli and should be fixed there. Maybe you might just have to live with a local patch to reorder the various -I directories for your system or you may have to deactivate brotli while building ngx_brotli. Upstream should be aware that this will likely also pop up on other distributions in the future (for example, Debian testing also ships libbrotli1 and libbrotli-dev which provides /usr/lib/libbrotli*.so and corresponding headers).

comment:3 Changed 2 years ago by raimue (Rainer Müller)

Resolution: invalid
Status: assignedclosed
Note: See TracTickets for help on using tickets.