gegl: fails to build against ffmpeg-devel

[Ionic (Mihai Moldovan)]

:info:build ff-load.c:312:36: error: use of undeclared identifier 'CODEC_CAP_TRUNCATED'
:info:build       if (p->codec->capabilities & CODEC_CAP_TRUNCATED)
:info:build                                    ^
:info:build ff-load.c:313:26: error: use of undeclared identifier 'CODEC_FLAG_TRUNCATED'
:info:build         p->enc->flags |= CODEC_FLAG_TRUNCATED;
:info:build                          ^
:info:build 9 warnings and 2 errors generated.

Not sure if these can be easily patched out and whether that's the only part that the build will stumble upon.

gegl 0.2 is dead, only used by the stable gimp2 port; users of the ffmpeg port will only hit this problem as soon as ffmpeg releases a new version (given that the last one was released half a year ago, chances aren't too bad that it will happen some time soonish).

[dbevans (David B. Evans)]

Yes, ffmpeg-devel breaks both API and ABI with the current ffmpeg, both signs that a new major release with API changes will be coming before long.

In the case of GEGL, the constants CODEC_CAP_TRUNCATED and CODEC_FLAG_TRUNCATED where renamed to AV_CODEC_CAP_TRUNCATED and AV_CODEC_FLAG_TRUNCATED several years ago.

The current ffmpeg version includes aliases of the form

#define CODEC_CAP_TRUNCATED AV_CODEC_CAP_TRUNCATED
#define CODEC_FLAG_TRUNCATED AV_CODEC_FLAG_TRUNCATED

In the latest ffrmpeg-devel these aliases have finally been dropped. The fix is relatively simple and I'm testing it now. Both ffmpeg and ffmpeg-devel recognize the newer API.

There's likely to be similar problems with other ffmpeg dependents when building with ffmpeg-devel.

[dbevans (David B. Evans)]

See #55389 for a similar problem with gegl-devel (and probably gegl-0.3 as well).

[dbevans (David B. Evans)]

In 21cb4154f2aed8b413b0aea0ace2289bc12ec431/macports-ports:

gegl: update to version 0.2.0 git maintenance branch as of 20180218

• rebase patches
• install pre-generated gegl/gegl-enums.c to avoid build time generation failure
• update ffmpeg patch to address build issue with ffmpeg-devel
• remove broken ff-save operation from +workshop build

Closes #55894