Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#55939 closed defect (fixed)

reclaim does not support distfile tags

Reported by: ryandesign (Ryan Schmidt) Owned by: raimue (Rainer Müller)
Priority: Normal Milestone: MacPorts 2.4.4
Component: base Version: 2.4.99
Keywords: Cc:
Port:

Description

port reclaim does not support tags -- the labels that can be added after a colon to distfiles and master_sites values to group them.

A port might specify its distfiles as:

distfiles           foo.tar.gz:foosite \
                    bar.tar.gz:barsite

This means "download the file 'foo.tar.gz' from the site with the tag 'foosite' and the file 'bar.tar.gz' from the site with the tag 'barsite'". Such a port would then specify its master_sites as:

master_sites        https://foo.example.com/fooproject/:foosite \
                    https://bar.example.com/barproject/:barsite

This would cause MacPorts to download the files https://foo.example.com/fooproject/foo.tar.gz and https://bar.example.com/barproject/bar.tar.gz.

port reclaim is not aware of this feature; it just uses each element of distfiles literally. So it checks the disk for the files "foo.tar.gz:foosite" and "bar.tar.gz:barsite", which of course don't exist.

Implementing support for tags requires using the procedures getdistsite and getdisttag from portutil.tcl. Take a look at the other places in base that use these procedures.

Change History (4)

comment:1 Changed 3 years ago by raimue (Rainer Müller)

Owner: set to raimue
Resolution: fixed
Status: newclosed

In 3ad97625cc57d26e333dcdf06dc0d932f002056a/macports-base:

reclaim: Split distfile into filename and disttag

Closes: #55939

comment:2 Changed 3 years ago by raimue (Rainer Müller)

Milestone: MacPorts 2.5.0

comment:3 Changed 3 years ago by raimue (Rainer Müller)

In 22dd6dd58c7440886a681514cb866ef4e3b5db01/macports-base:

reclaim: Split distfile into filename and disttag

Closes: #55939
(cherry picked from commit 3ad97625cc57d26e333dcdf06dc0d932f002056a)

comment:4 Changed 3 years ago by ryandesign (Ryan Schmidt)

Milestone: MacPorts 2.5.0MacPorts 2.4.4
Note: See TracTickets for help on using tickets.