Opened 3 years ago

Closed 2 years ago

#56168 closed update (duplicate)

gnome-internet-radio-locator 1.0.7 +quartz

Reported by: oleaamot (Ole Aamot) Owned by:
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: gnome-internet-radio-locator

Description

gnome-internet-radio-locator 1.0.7 is available for free under GNU General Public License version 3 (or later) from ​​​​​​https://download.gnome.org/sources/gnome-internet-radio-locator/1.0/gnome-internet-radio-locator-1.0.7.tar.xz with Norwegian bokmål translation.

See the attached diff for the new Portfile against ​​​​​​https://github.com/macports/macports-ports/blob/master/gnome/gnome-internet-radio-locator/Portfile

Best, Ole

Attachments (1)

Portfile-1.0.7.diff (1.8 KB) - added by oleaamot (Ole Aamot) 3 years ago.
gnome-internet-radio-locator 1.0.7

Download all attachments as: .zip

Change History (4)

Changed 3 years ago by oleaamot (Ole Aamot)

Attachment: Portfile-1.0.7.diff added

gnome-internet-radio-locator 1.0.7

comment:1 Changed 3 years ago by ryandesign (Ryan Schmidt)

The update to 1.0.7 is fine, but the rest is not:

  • There are two nested pre-configure blocks.
  • You're enabling the gtk3 and x11 variants by default, but the port doesn't have any such variants. I'm assuming you meant to add them, but forgot?
  • You're checking whether gtk3 is installed with +quartz by checking for the existence of a file; that method has been obsolete for years. Instead, please use PortGroup active_variants 1.1 (at the top of the Portfile) and require_active_variants gtk3 +quartz (in the quartz variant—assuming the quartz variant were changed to declare that it requires the thus far nonexistent gtk3 variant).
  • I am assuming here that gnome-internet-radio-locator builds itself in some way differently when gtk3 is installed with quartz vs when it is not; otherwise, it wouldn't make sense to declare an empty quartz variant.

comment:2 Changed 2 years ago by oleaamot (Ole Aamot)

I removed quartz from the Portfile. See #56306

Thanks.

comment:3 Changed 2 years ago by raimue (Rainer Müller)

Resolution: duplicate
Status: newclosed

Superseded by #56306.

Note: See TracTickets for help on using tickets.