newsboat: You need package ncurses5.4 in order to compile this program

[ryandesign (Ryan Carsten Schmidt)]

From the buildbot:

Executing:  cd "/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_net_newsboat/newsboat/work/newsboat-2.10.1" && /usr/bin/make -j2 -w all doc prefix=/opt/local CXX=/opt/local/bin/g++-mp-6 
DEBUG: system:  cd "/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_net_newsboat/newsboat/work/newsboat-2.10.1" && /usr/bin/make -j2 -w all doc prefix=/opt/local CXX=/opt/local/bin/g++-mp-6 
make: Entering directory `/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_net_newsboat/newsboat/work/newsboat-2.10.1'
Makefile:30: config.mk: No such file or directory
Checking for package sqlite3... found
Checking for package libcurl... found
Checking for package libxml-2.0... found
Checking for package stfl... found
Checking for package json... not found
Checking for package json-c... found
Checking for package ncurses5.4 using ncurses5.4-config... not found

You need package ncurses5.4 in order to compile this program.
Please make sure it is installed.

You can download ncurses5.4 from here: 
Checking for package libcrypto... found

One or more dependencies couldn't be found. Please install
these packages and retry compilation.
make: *** [config.mk] Error 1

[Raimondi (Israel Chauca Fuentes)]

I'm not sure how to debug that. I have /usr/bin/ncurses5.4-config in my machine and pkgutil --file-info /usr/bin/ncurses5.4-config gives the following:

volume: /
path: /usr/bin/ncurses5.4-config

pkgid: com.apple.pkg.Core
pkg-version: 10.13.3.1.1.1516347890
install-time: 1520630561
uid: 0
gid: 0
mode: 755

sudo port build newsboat ends with no error here. Why could it be that ncurses5.4-config is not available in that machine?

[ryandesign (Ryan Carsten Schmidt)]

Well, for one thing, the newsboat port declares a dependency on the ncurses port, which is at version 6.1 and provides ncurses6-config. Why is newsboat looking for the older ncurses5.4-config? It looks like the config.sh script has the ability to check for a dependency's existence using pkg-config, and does so for the other dependencies, but doesn't do that for ncurses. I'd probably start by patching config.sh to use pkg-config to find ncurses too.

[Raimondi (Israel Chauca Fuentes)]

I get it, no external dependencies is the goal. I have a working patch for this issue but I also need to update the version of the port, should I add the version patch here or create a new ticket?

[ryandesign (Ryan Carsten Schmidt)]

It's fine to do both changes at once. If you can submit a pull request on GitHub, that's probably best, but if you prefer you can attach patchfiles to this ticket.

[Raimondi (Israel Chauca Fuentes)]

In c06e4b731afed10a8e9a67389a19abf3a1aa81d8/macports-ports (master):

newsboat: update version and fix dependency

• update version to 2.11.1
• remove hard dependency on ncurses5.4

Closes: #56403