Opened 2 years ago

Closed 11 days ago

#56787 closed enhancement (fixed)

gdal: add fits variant

Reported by: mazhe (Matthieu Volat) Owned by: Veence (Vincent)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: gdal

Description

Hello,

The gdal library can have support for the FITS image format used in astronomy through the cfitsio project. While gdal already have a lot of variants, it would be super useful to have this one added.

Attached is a patch to the Portfile that allows this, could this be commited to the port?

Thank you very much for your time,

Attachments (1)

gdal_fits_variant.diff (516 bytes) - added by mazhe (Matthieu Volat) 2 years ago.
Simpler patch.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 2 years ago by kencu (Ken)

Keywords: haspatch added; gdal fits removed
Owner: set to Veence
Port: gdal added; gis/gdal removed
Status: newassigned
Summary: add fits variant to gis/gdalrequest to add fits variant to gis/gdal

comment:2 Changed 2 years ago by kencu (Ken)

To make this variant work the way you want it to, you'd have to leave

--without-cfitsio \

as it is in the default configure arguments (as you want it off by default).

Then, in your variant, you can do this replacement:

variant fits description {Enable FITS file format} {
    depends_lib-append       port:cfitsio
    configure.args-replace   --without-cfitsio    --with-cfitsio
}

Changed 2 years ago by mazhe (Matthieu Volat)

Attachment: gdal_fits_variant.diff added

Simpler patch.

comment:3 Changed 2 years ago by mazhe (Matthieu Volat)

Ho, thanks. I'm not that familiar with Portfile syntax, I just copied what was done in other parts of the file.

Here's an updated version.

comment:4 Changed 2 years ago by kencu (Ken)

Yeah, I think that should do it. Let's give Vince (the maintainer) time to check it out now. -- K

comment:5 Changed 2 years ago by mazhe (Matthieu Volat)

Hi, is there any progress or comment regarding this request? priority is not that high, but it would be nice to have it done!

Thanks again,

comment:6 Changed 2 years ago by kencu (Ken)

Vince hasn't noticed this one so far I guess.

I'll put together a PR for this (or you can if you like). Then it will get committed after a short while if it passes muster on the CI system.

comment:7 Changed 2 years ago by Veence (Vincent)

Oops. I apologize. Will work on this tonight.

comment:8 Changed 11 days ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: assignedclosed
Summary: request to add fits variant to gis/gdalgdal: add fits variant
Note: See TracTickets for help on using tickets.