Opened 6 years ago
Closed 6 years ago
#56903 closed defect (fixed)
SuiteSparse_config: config picks up icc compiler and fails
| Reported by: | petrrr | Owned by: | michaelld (Michael Dickens) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.5.3 |
| Keywords: | Cc: | ||
| Port: | SuiteSparse_config |
Description
With the update of SuiteSparse I noticed, that the subport SuiteSparse_config fails because the config phase now picks up a icc. This behaviour is new, before the icc compiler did not cause problems.
In any case, I believe the config procedure should not pick up an arbitrary compiler from the host it is running on in order to avoid any issues.
Log attached.
Attachments (2)
Change History (7)
Changed 6 years ago by petrrr
| Attachment: | SuiteSparse_config.main.log added |
|---|
comment:1 Changed 6 years ago by michaelld (Michael Dickens)
Looks like the SS Makefile isn't honoring the provided "CC" (etc) environment variables. how naughty! I know they are slowly converting to using CMake, which will solve this issue. In the meantime, I'll poke at it & see if there's a quick fix.
comment:2 Changed 6 years ago by michaelld (Michael Dickens)
Can you try this patch & see if it does the trick?
Changed 6 years ago by michaelld (Michael Dickens)
| Attachment: | SuiteSparse_honor_CC.diff added |
|---|
comment:3 Changed 6 years ago by petrrr
The test I am now doing is not 100% identical because I worked around the issue before. But I reproduced the problem and the patch fixes it.
So Yes it should do the trick! Thanks for looking it this so fast.
comment:4 Changed 6 years ago by michaelld (Michael Dickens)
OK thx for the quick feedback. I'll go ahead and push that fix. and .. YW! I had the time & this turned out to be easy (much easier than the other problems I'm working on right now).
comment:5 Changed 6 years ago by michaelld (Michael Dickens)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
main.log