Opened 6 years ago

Closed 6 years ago

#56978 closed defect (fixed)

glfw @a94a84b507b0d6d11e8a3f257cb21f4bd6553516: Unsuitable version number

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: michaelld (Michael Dickens)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: glfw

Description

The version of the glfw port on Snow Leopard is a94a84b507b0d6d11e8a3f257cb21f4bd6553516:

$ port info glfw os.major=10 | head -n 1
glfw @a94a84b507b0d6d11e8a3f257cb21f4bd6553516 (graphics)

This is not a suitable value to use for a version number. A version number should be a dotted decimal like 3.2, or a date like 20151018, or even a combination of the two like 3.2-20151018.

The version was changed to this value in [24315638124bb91870778b03f555038acd17a9b6/macports-ports].

Prior to this change, the last version of the port that built on Snow Leopard was apparently 3.1.2. The MacPorts vercmp procedure considers 3.1.2 to be greater than a94a84b507b0d6d11e8a3f257cb21f4bd6553516. So existing users of glfw 3.1.2 on Snow Leopard have not been informed of the availability of this update, since the epoch was not increased.

Instead of increasing the epoch, please set the version to a suitable dotted decimal value that MacPorts considers to be greater than 3.1.2.

Change History (3)

comment:1 Changed 6 years ago by michaelld (Michael Dickens)

Wow I really messed up that commit. From this list (the search for "Remove support for OS X 10.6"), it looks like this commit (f62084ff, dated Oct 24, 2015) is the final one before 10.6 support was removed, so I'm going to use it instead of the one currently in the Portfile. I will test out a suitable version that's "greater than" 3.1.2 by MP vercmp, preferably without bumping the epoch.

comment:2 Changed 6 years ago by michaelld (Michael Dickens)

Looks like GLFW 3.1.2 doesn't work with Mac OS X 10.5 ... some of the CoreGraphics references are 10.6+. So, I'm going to error out pre-fetch when on 10.5 or older. Not much point in trying to go back, if it hasn't been available for 2+ years there LOL.

comment:3 Changed 6 years ago by michaelld (Michael Dickens)

Resolution: fixed
Status: assignedclosed

In 5d9312ff5d231c890da29702d1017ac49dcacb1a/macports-ports (master):

glfw: Mac OS X 10.6 only: set the version to be useful

+ "3.1.2-20151024" is "greater" than "3.1.2" or "a94a84..." to MacPorts vercmp
+ leave the commit alone, since it is actually the final commit to build on 10.6.

Closes: #56978

Note: See TracTickets for help on using tickets.