paraview @5.5.0_1 Document copy error - build failure

[majoc-at-astro (majoc-at-astro)]

Build of paraview +openmpi fails; please see attached. First sign of trouble seems to be failing to copy directory work/ParaView-v5.5.0/Plugins/StreamLinesRepresentation/doc to work/build/Plugins/StreamLinesRepresentation/doc. This affects macOS 10.11--10.13 for us, with the latest compatible Xcode for each.

Build without +openmpi in progress .... ah: an identical failure, which I'll also attach. Please let me know if you require other information.

[majoc-at-astro (majoc-at-astro)]

paraview +openmpi logfile, macOS 10.13

[majoc-at-astro (majoc-at-astro)]

Apologies: now I look more closely at the log for the second build attempt, the dependencies of paraview forced +openmpi to be on, and I now can't add +openmpi back to the subject line. Let me know, please, whether I should send the second log for completeness.

[jjstickel (Jonathan Stickel)]

I recall that +openmpi didn't work for me either. However, building paraview after the recent revision bump failed for me even without openmpi, so the situation may be worse than that. I will take me a few days to look into it. In the meantime, patches are welcome!

[rubendibattista (Ruben Di Battista)]

The problem seems related to a missing include for QHeaderView:

:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_paraview/paraview/work/ParaView-v5.5.0/Qt/Components/pqChangeInputDialog.cxx:81:45: error: member access into incomplete type 'QHeaderView'
:info:build   this->Internals->pipelineView->getHeader()->hide();
:info:build                                             ^
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_paraview/paraview/work/ParaView-v5.5.0/Qt/Widgets/pqFlatTreeView.h:53:7: note: forward declaration of 'QHeaderView'
:info:build class QHeaderView;
:info:build       ^
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_paraview/paraview/work/ParaView-v5.5.0/Qt/Components/pqChangeInputDialog.cxx:83:45: error: member access into incomplete type 'QHeaderView'
:info:build   this->Internals->pipelineView->getHeader()->hideSection(1);
:info:build                                             ^
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_paraview/paraview/work/ParaView-v5.5.0/Qt/Widgets/pqFlatTreeView.h:53:7: note: forward declaration of 'QHeaderView'
:info:build class QHeaderView;
:info:build       ^
:info:build 2 errors generated.

Is then also normal that in the Portfile it uses both qt4-mac-sqlite-plugin and qt5-qttools? Should not be the same QT version?

[rubendibattista (Ruben Di Battista)]

Ok, I have a patch. Needed to fix some source files adding the includes for the incomplete types and moreover also fixed the OP error fixing a CMakeLists.txt.

Could you check if this work for you?

PS: I also bumped the version to 5.5.2.

[rubendibattista (Ruben Di Battista)]

I switched to use only qt5 ports. Needed to fix a bit also the cmake config lines.

[majoc-at-astro (majoc-at-astro)]

Replying to rubendibattista:

Ok, I have a patch. Needed to fix some source files adding the includes for the incomplete types and moreover also fixed the OP error fixing a CMakeLists.txt.

For the record, I see two other instances of qt5-related incomplete type errors (lyx, and librecad) in this morning's build. I'll submit separate tickets on those in due course, if someone doesn't beat me to it.

Could you check if this work for you?

Will do, once the update has propagated. Many thanks.

[jjstickel (Jonathan Stickel)]

I see that the PR has already been merged, but when I tried to build with -mpich +python36, I get this error (from the log):

:info:build /opt/local/var/macports/build/_Users_Shared_install_macports_ports_science_paraview/paraview/work/ParaView-v5.5.2/Qt/Python/pqPythonShell.cxx:128:20: error: member access into incomplete type 'QAbstractItemView'
:info:build       this->popup()->setCurrentIndex(this->completionModel()->index(0, 0));
:info:build                    ^
:info:build /opt/local/libexec/qt5/lib/QtWidgets.framework/Headers/qcompleter.h:55:7: note: forward declaration of 'QAbstractItemView'
:info:build class QAbstractItemView;
:info:build       ^

So it looks like some of the files in Qt/Python/ also need more include lines. If you have suggestions, I'm happy to hack the sources and retest. Also, has anyone reported upstream?

[majoc-at-astro (majoc-at-astro)]

Replying to majoc-at-astro:

Replying to rubendibattista:

Could you check if this work for you?

Will do, once the update has propagated. Many thanks.

It's propagated, and builds for us. Again thanks.

[jjstickel (Jonathan Stickel)]

I extended the patch for qt5 compatibility so now the +python36 variant works. See ​https://github.com/macports/macports-ports/pull/2468. When that pull request is merged, this ticket should close.

[jjstickel (Jonathan Stickel)]

In 7d88831dafb472dbf496681b0219248491d7f5ca/macports-ports (master):

paraview: fix python36 variant

• adds to patch for qt5 compatibility

Closes: #56981