#57197 closed update (fixed)

iTerm2: Update to 3.2.5

Reported by: ryandesign (Ryan Schmidt) Owned by: markemer (Mark Anderson)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: rlhamil
Port: iTerm2

Description (last modified by l2dy (Zero King))

$ port livecheck iTerm2
iTerm2 seems to have been updated (port version: 3.2.0, new version: 3.2.2)

Change History (9)

comment:1 Changed 23 months ago by l2dy (Zero King)

Description: modified (diff)
Summary: iTerm2: Update to 3.2.1iTerm2: Update to 3.2.2

comment:2 Changed 22 months ago by rlhamil

Cc: rlhamil added

comment:3 Changed 22 months ago by stanimura

iTerm2 is now 3.2.5.

$ port livecheck iTerm2
iTerm2 seems to have been updated (port version: 3.2.0, new version: 3.2.5)

comment:4 Changed 22 months ago by markemer (Mark Anderson)

I'm currently working on 3.2.5 - but it dies in a funny place. I'm investigating.

comment:5 Changed 21 months ago by markemer (Mark Anderson)

Can we update this title to 3.2.5 - and also, the problem I'm having is related to #57137 - but I can't seem to get ${xcode.target} to work for me, the port command pleads ignorance.

comment:6 in reply to:  5 Changed 21 months ago by ryandesign (Ryan Schmidt)

Summary: iTerm2: Update to 3.2.2iTerm2: Update to 3.2.5

Replying to markemer:

Can we update this title to 3.2.5

Done.

and also, the problem I'm having is related to #57137

I had hoped someone using Mojave would have fixed that by now.

but I can't seem to get ${xcode.target} to work for me, the port command pleads ignorance.

What do you mean?

comment:7 Changed 21 months ago by markemer (Mark Anderson)

Ok, I worked it out, I'm not not using the Xcode portgroup because there is a makefile and the Xcode portgroup doesn't play well with makefiles. But now I'm back to my starting problem, where 3.2.5 won't build on 10.14 which is the system I'm developing on. I think I may have to change the Makefile patch to include adding -derivedData

Last edited 21 months ago by markemer (Mark Anderson) (previous) (diff)

comment:8 Changed 21 months ago by ryandesign (Ryan Schmidt)

Yes, on Xcode 10 or later I think we need to use -derivedData. We should do that in the xcode portgroup, and ports that invoke xcodebuild manually would have to add that as well.

The question is: is there a good reason why the iTerm2 port should use that Makefile? It looks like almost all of what the Makefile does is of use only to the developer, not to us. Literally all it's doing in the build phase (the Deployment target) is

	xcodebuild -parallelizeTargets -target iTerm2 -configuration Deployment && \
	chmod -R go+rX build/Deployment

and the destroot phase (the install target) is just:

	cp -R build/Deployment/iTerm2.app $(APPS)

It should be extremely easy to replace that with the xcode portgroup, and then you'd automatically get the benefit of any improvement made to that portgroup.

comment:9 Changed 21 months ago by yan12125 (Chih-Hsuan Yen)

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.