miriad: Error: Actual argument contains too few elements for dummy argument 'grphdr'

[ryandesign (Ryan Carsten Schmidt)]

​miriad does not build:

code/rpfitsin.f:551:30:

          call GETPARM (jstat, grphdr, i_grphdr, 1, bufptr, buffer,
                              1
Error: Actual argument contains too few elements for dummy argument 'grphdr' (11/640) at (1)
make[2]: *** [code/rpfitsin.lo] Error 1
make[2]: *** Waiting for unfinished jobs....

[pkgw (Peter Williams)]

Compile fixes for GCC 8.1

[pkgw (Peter Williams)]

This problem is due to some new, stricter array size checking in gfortran 8.1: ​https://groups.google.com/forum/#!topic/comp.lang.fortran/x3JnAjRX-KA

The attached patch should fix the build failures.

I still pay attention to this project and package, but I do not expect to see MIRIAD ever have another official release, so I think it is best to apply the patch in the package.

[ryandesign (Ryan Carsten Schmidt)]

Thanks for the patch.

You're the maintainer, so you should supply everything that needs to be committed, including the changes to the portfile, and ideally as a pull request, though attaching files to a Trac ticket is fine too.

Your new patch is in p1 format, while the port's existing patchfile is in p0 format; all of a port's patchfiles must use the same format.

Your new patch also patches Makefile.am, so autoreconf will need to be run (or rewrite it to patch Makefile.in instead).

This new patch is for gfortran8 compatibility... is it safe to use it for all gfortran versions or should it be restricted to gfortran8 and later?

While we're making changes to the port, in your patch, please change the maintainers line to include your GitHub handle (i.e. maintainer {newton.cx:peter @pkgw} openmaintainer).

[pkgw (Peter Williams)]

I literally didn't even know that MacPorts had migrated to GitHub! (Yes, I've been very disengaged.) I will prep a PR.

[ryandesign (Ryan Carsten Schmidt)]

​Indeed we have! We've had some time to get used to this new way of working so if you have any questions let us know. The ​macports-dev mailing list is a good place to ask.

[pkgw (Peter Williams)]

Filed as ​https://github.com/macports/macports-ports/pull/2899 . Haven't been able to fully test and vet yet, but I wanted to get it in the system.

[pkgw (Peter Williams)]

In 54e00450540c9ba40e11cd75062fe535916f7817/macports-ports (master):

miriad: fix compilation on gfortran >= 8.1

As per #57434 . The most recent gfortran adds
a new error that gets triggered in this package. It is unlikely that we'll
see a new upstream release, so we add a new patch to fix the problems.

Also, register my GitHub username (@pkgw).

Also, remove the old mm.f2c debugging patch; the problem seems to be solved.
At least, I have not heard any reports of problems for literally years.

Closes: #57434.