Changes between Initial Version and Version 1 of Ticket #57765, comment 9


Ignore:
Timestamp:
Dec 14, 2018, 3:47:58 PM (5 years ago)
Author:
mf2k (Frank Schima)
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #57765, comment 9

    initial v1  
    11Some comments on your pdsh patch:
    2  - You should be able to remove the {{{master_sites}}} line by setting github.tarball_from releases}}}
     2 - You should be able to remove the {{{master_sites}}} line by setting {{{github.tarball_from releases}}}
    33 - There are too many variants being added IMHO. Can they all just be incorporated directly and not make them variants at all?
    44 - For the {{{no_rsh}}} variant, we long ago excised such "negative" variants for consistency. You made it the default, so is there a reason not to have rsh functionality built? If so, name the variant {{{rsh}}} and do not make it a default variant.