Opened 2 years ago

#57857 new defect

p5-git-raw: broken on < 10.8 (error: use of undeclared identifier 'kSSLClientSide')

Reported by: mojca (Mojca Miklavec) Owned by:
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: dbevans (David B. Evans), ci42
Port: p5-git-raw

Description

/usr/bin/clang -c  -I. -Ideps/libgit2 -Ideps/libgit2/src -Ideps/libgit2/include -Ideps/libgit2/deps/http-parser -Ideps/libgit2/deps/zlib -I/opt/local/include -fno-common -DPERL_DARWIN -mmacosx-version-min=10.7 -pipe -Os  -fno-strict-aliasing -fstack-protector -I/opt/local/include -DPERL_USE_SAFE_PUTENV  -Wall -Wno-unused-variable -Wno-pedantic -Wno-deprecated-declarations -Wno-unused-const-variable -Wno-unused-function -arch x86_64 -O3   -DVERSION=\"0.82\" -DXS_VERSION=\"0.82\"  "-I/opt/local/lib/perl5/5.26/darwin-thread-multi-2level/CORE"  -DGIT_SSH -DGIT_OPENSSL -DGIT_SHA1_OPENSSL -DGIT_HTTPS -DGIT_CURL -DNO_VIZ -DSTDC -DNO_GZIP -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -DLIBGIT2_NO_FEATURES_H -DGIT_USE_STAT_MTIMESPEC -DGIT_USE_STAT_MTIM_NSEC -DGIT_USE_NEC -DGIT_SECURE_TRANSPORT -DGIT_HTTPS -DGIT_SHA1_COMMON_CRYPTO -DGIT_THREADS deps/libgit2/src/streams/stransport.c -o deps/libgit2/src/streams/stransport.o
clang: warning: unknown warning option '-Wno-unused-const-variable'; did you mean '-Wno-unused-variable'?
warning: unknown warning option '-Wno-unused-const-variable'; did you mean '-Wno-unused-variable'? [-Wunknown-warning-option]
deps/libgit2/src/streams/stransport.c:262:12: warning: implicit declaration of function 'SSLCreateContext' is invalid in C99 [-Wimplicit-function-declaration]
        st->ctx = SSLCreateContext(NULL, kSSLClientSide, kSSLStreamType);
                  ^
deps/libgit2/src/streams/stransport.c:262:35: error: use of undeclared identifier 'kSSLClientSide'
        st->ctx = SSLCreateContext(NULL, kSSLClientSide, kSSLStreamType);
                                         ^
deps/libgit2/src/streams/stransport.c:272:13: warning: implicit declaration of function 'SSLSetProtocolVersionMin' is invalid in C99 [-Wimplicit-function-declaration]
            (ret = SSLSetProtocolVersionMin(st->ctx, kTLSProtocol1)) != noErr ||
                   ^
deps/libgit2/src/streams/stransport.c:273:13: warning: implicit declaration of function 'SSLSetProtocolVersionMax' is invalid in C99 [-Wimplicit-function-declaration]
            (ret = SSLSetProtocolVersionMax(st->ctx, kTLSProtocol12)) != noErr ||
                   ^
deps/libgit2/src/streams/stransport.c:273:47: error: use of undeclared identifier 'kTLSProtocol12'; did you mean 'kTLSProtocol1'?
            (ret = SSLSetProtocolVersionMax(st->ctx, kTLSProtocol12)) != noErr ||
                                                     ^~~~~~~~~~~~~~
                                                     kTLSProtocol1
/System/Library/Frameworks/Security.framework/Headers/SecureTransport.h:88:2: note: 'kTLSProtocol1' declared here
        kTLSProtocol1,                          /* TLS 1.0 preferred, lower versions OK */
        ^
4 warnings and 2 errors generated.

See a sample patch: https://github.com/libgit2/libgit2/pull/3389

Change History (0)

Note: See TracTickets for help on using tickets.