logrotate @3.15.0 fails to build on High Sierra

[Schamschula (Marius Schamschula)]

While upgrading logrotate on my High Sierra machine I get:

/usr/bin/clang -DHAVE_CONFIG_H -I.  -include config.h -I/opt/local/include -Wall -Wextra -Wmissing-format-attribute -Wmissing-noreturn -Wpointer-arith -Wshadow -Wstrict-prototypes -Wundef -Wunused -Wwrite-strings -pipe -Os -arch x86_64 -MT logrotate.o -MD -MP -MF .deps/logrotate.Tpo -c -o logrotate.o logrotate.c
logrotate.c:478:38: warning: unused parameter 'acl' [-Wunused-parameter]
                            acl_type acl, int force_mode)
                                     ^
logrotate.c:694:17: error: no member named 'st_atim' in 'struct stat'
    ts[0] = sb->st_atim;
            ~~  ^
logrotate.c:695:17: error: no member named 'st_mtim' in 'struct stat'
    ts[1] = sb->st_mtim;
            ~~  ^
1 warning and 2 errors generated.

Ryan ran into a similar problem with optipng: see ​https://sourceforge.net/p/optipng/bugs/47/, so I patched logrotate.c, see attached files.

[ctreleaven (Craig Treleaven)]

Thanks for the report and identifying the fix. I'll report to upstream and add the patch for now.

BTW, I did not receive a failure report from our buildbots. Should I not have?

[ctreleaven (Craig Treleaven)]

In b391c4e3794b9681660e4aa44cfa6c48b6e66575/macports-ports (master):

logrotate: add patch for timer problem

Patch by @Schamschula to address problem on 10.13 with hi-res timing

Fixes: #58045