stellarium @0.19.1: error: missing default argument on parameter

[kencu (Ken)]

This error occurs on 10.7, building with the default clang version:

:info:build In file included from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_stellarium/stellarium/work/stellarium-0.19.1/plugins/ArchaeoLines/src/ArchaeoLines.cpp:33:
:info:build In file included from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_stellarium/stellarium/work/stellarium-0.19.1/src/core/modules/SolarSystem.hpp:30:
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_stellarium/stellarium/work/stellarium-0.19.1/src/core/modules/Planet.hpp:687:80: error: expected ')'
:info:build                                                   const QMap<QByteArray,int>& fixedAttributeLocations=QMap<QByteArray,int>());
:info:build                                                                                                                          ^
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_stellarium/stellarium/work/stellarium-0.19.1/src/core/modules/Planet.hpp:682:43: note: to match this '('
:info:build         static QOpenGLShaderProgram* createShader(const QString& name,
:info:build                                                  ^
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_stellarium/stellarium/work/stellarium-0.19.1/src/core/modules/Planet.hpp:687:76: error: expected '>'
:info:build                                                   const QMap<QByteArray,int>& fixedAttributeLocations=QMap<QByteArray,int>());
:info:build                                                                                                                      ^
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_stellarium/stellarium/work/stellarium-0.19.1/src/core/modules/Planet.hpp:687:80: error: missing default argument on parameter
:info:build                                                   const QMap<QByteArray,int>& fixedAttributeLocations=QMap<QByteArray,int>());
:info:build                                                                                                                          ^
:info:build 3 errors generated.
:info:build make[2]: *** [plugins/ArchaeoLines/src/CMakeFiles/ArchaeoLines-static.dir/ArchaeoLines.cpp.o] Error 1

forcing the build to use clang-5.0 works.

[kencu (Ken)]

Given the upcoming changes in MacPorts, I'm not testing against anything less than clang-5.0 any longer.

I'm not sure which MacOS clang version passes the test to build this, ie where the clang version line should be drawn. There is nothing about stellarium on packages.macports.org to shed light on this, either, I'm afraid.

[ryandesign (Ryan Carsten Schmidt)]

In d40aeb4521bab13f5e9800cc0c7387cb10db0599/macports-ports (master):

stellarium: Set C and C++ standards to 2011

See: #58820

[kencu (Ken)]

setting the c++ standard in the portfile to 2011 causes clang-9.0 to be called in on 10.7, and this defaulting ​works.

[michaelld (Michael Dickens)]

Nice! Glad moving to modern standards helps with older OSs!