Opened 18 months ago

Closed 8 months ago

Last modified 8 months ago

#58820 closed defect (fixed)

stellarium @0.19.1: error: missing default argument on parameter

Reported by: kencu (Ken) Owned by: michaelld (Michael Dickens)
Priority: Normal Milestone:
Component: ports Version:
Keywords: lion Cc:
Port: stellarium

Description

This error occurs on 10.7, building with the default clang version:

:info:build In file included from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_stellarium/stellarium/work/stellarium-0.19.1/plugins/ArchaeoLines/src/ArchaeoLines.cpp:33:
:info:build In file included from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_stellarium/stellarium/work/stellarium-0.19.1/src/core/modules/SolarSystem.hpp:30:
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_stellarium/stellarium/work/stellarium-0.19.1/src/core/modules/Planet.hpp:687:80: error: expected ')'
:info:build                                                   const QMap<QByteArray,int>& fixedAttributeLocations=QMap<QByteArray,int>());
:info:build                                                                                                                          ^
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_stellarium/stellarium/work/stellarium-0.19.1/src/core/modules/Planet.hpp:682:43: note: to match this '('
:info:build         static QOpenGLShaderProgram* createShader(const QString& name,
:info:build                                                  ^
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_stellarium/stellarium/work/stellarium-0.19.1/src/core/modules/Planet.hpp:687:76: error: expected '>'
:info:build                                                   const QMap<QByteArray,int>& fixedAttributeLocations=QMap<QByteArray,int>());
:info:build                                                                                                                      ^
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_science_stellarium/stellarium/work/stellarium-0.19.1/src/core/modules/Planet.hpp:687:80: error: missing default argument on parameter
:info:build                                                   const QMap<QByteArray,int>& fixedAttributeLocations=QMap<QByteArray,int>());
:info:build                                                                                                                          ^
:info:build 3 errors generated.
:info:build make[2]: *** [plugins/ArchaeoLines/src/CMakeFiles/ArchaeoLines-static.dir/ArchaeoLines.cpp.o] Error 1

forcing the build to use clang-5.0 works.

Attachments (1)

stellarium-fail-10.7.log.zip (41.5 KB) - added by kencu (Ken) 18 months ago.

Download all attachments as: .zip

Change History (5)

Changed 18 months ago by kencu (Ken)

comment:1 Changed 18 months ago by kencu (Ken)

Given the upcoming changes in MacPorts, I'm not testing against anything less than clang-5.0 any longer.

I'm not sure which MacOS clang version passes the test to build this, ie where the clang version line should be drawn. There is nothing about stellarium on packages.macports.org to shed light on this, either, I'm afraid.

comment:2 Changed 10 months ago by ryandesign (Ryan Schmidt)

In d40aeb4521bab13f5e9800cc0c7387cb10db0599/macports-ports (master):

stellarium: Set C and C++ standards to 2011

See: #58820

comment:3 Changed 8 months ago by kencu (Ken)

Resolution: fixed
Status: assignedclosed

setting the c++ standard in the portfile to 2011 causes clang-9.0 to be called in on 10.7, and this defaulting works.

comment:4 Changed 8 months ago by michaelld (Michael Dickens)

Nice! Glad moving to modern standards helps with older OSs!

Note: See TracTickets for help on using tickets.