Opened 17 months ago

Closed 14 months ago

Last modified 9 months ago

#59235 closed defect (fixed)

MacVim fails to build on macOS 10.15 Catalina

Reported by: moyang (Moyang Wang) Owned by: raimue (Rainer Müller)
Priority: Normal Milestone:
Component: ports Version: 2.6.1
Keywords: Cc: sitrucz1 (Curtis Matz), jmgoicolea (Jose Goicolea), rieder (Steven Rieder), mikealeonetti, vamsi765, pelzlpj (Paul Pelzl), gorticus (Jason Mitchell)
Port: MacVim

Description

The log file is attached.

Attachments (2)

main.log (102.4 KB) - added by moyang (Moyang Wang) 17 months ago.
main.2.log (20.8 KB) - added by mliker 17 months ago.

Download all attachments as: .zip

Change History (26)

Changed 17 months ago by moyang (Moyang Wang)

Attachment: main.log added

comment:1 Changed 17 months ago by jmroot (Joshua Root)

Owner: set to raimue
Status: newassigned

comment:2 Changed 17 months ago by mf2k (Frank Schima)

Keywords: Catalina 10.15 removed

It looks like a patch error.

comment:3 Changed 17 months ago by mliker

Cc: mliker added

comment:4 Changed 17 months ago by mliker

I believe the patch error only happens when there was already a previous unsuccessful build. The actual error is below. I don't get a patch error when I run port clean MacVim before running port upgrade MacVim

:info:patch --->  Running ibtool for Preferences.nib
:debug:patch system -W /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_editors_MacVim/MacVim/work/macvim-155: ibtool --compile src/MacVim/English.lproj/Preferences.nib/keyedobjects.nib src/MacVim/English.lproj/Preferences.nib
:info:patch xcode-select: error: tool 'ibtool' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance
:info:patch Command failed: ibtool --compile src/MacVim/English.lproj/Preferences.nib/keyedobjects.nib src/MacVim/English.lproj/Preferences.nib

Changed 17 months ago by mliker

Attachment: main.2.log added

comment:5 Changed 17 months ago by sitrucz1 (Curtis Matz)

Cc: sitrucz1 added

comment:6 Changed 17 months ago by jmgoicolea (Jose Goicolea)

Cc: jmgoicolea added

comment:7 in reply to:  4 Changed 16 months ago by hexadecagram (Anthony Chavez)

Replying to mliker:

I believe the patch error only happens when there was already a previous unsuccessful build. The actual error is below. I don't get a patch error when I run port clean MacVim before running port upgrade MacVim

I get the exact same error even with port clean MacVim or port clean --all MacVim. I have also tried sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer and it still produces the same error.

comment:8 Changed 16 months ago by rieder (Steven Rieder)

Likewise, for me also port clean macvim before port install macvim doesn't help at all.

comment:9 Changed 16 months ago by rieder (Steven Rieder)

Cc: rieder added

comment:10 Changed 16 months ago by nblievers

The first issue is fixed by adding use_xcode yes to the Portfile. But then there is a compilation error, which seems kinda weird. It is easy enough to fix :

--- src/MacVim/PSMTabBarControl/source/PSMTabBarCell.h~	2019-10-25 15:01:08.000000000 +1100
+++ src/MacVim/PSMTabBarControl/source/PSMTabBarCell.h	2019-10-25 14:55:23.000000000 +1100
@@ -32,6 +32,7 @@
     BOOL                _hasIcon;
     int                 _count;
     NSString            *_toolTip;
+    PSMTabBarControl   *_controlView;
 }
 
 // creation/destruction

Version 1, edited 16 months ago by nblievers (previous) (next) (diff)

comment:11 Changed 16 months ago by libsystem-ethan

Manually signing MacVim.app/Contents/MacOS/macvim-askpass, then rebuilding fixes the codesign error.

comment:12 Changed 16 months ago by mikealeonetti

Cc: mikealeonetti added

comment:13 Changed 16 months ago by vamsi765

Cc: vamsi765 added

comment:14 Changed 16 months ago by vamsi765

Is there any ETA on the fix to be delivered?

comment:15 Changed 16 months ago by dca58

Same question as above, any news on this ?

comment:16 Changed 15 months ago by pelzlpj (Paul Pelzl)

Cc: pelzlpj added

comment:17 Changed 15 months ago by gorticus (Jason Mitchell)

Cc: gorticus added

comment:18 in reply to:  10 Changed 15 months ago by majoc-at-astro (majoc-at-astro)

Replying to nblievers:

The first issue is fixed by adding use_xcode yes to the Portfile.

For completeness, I've found that necessary for our builds for 10.14 and 10.13 as well, though possibly for different reasons. Let me know if you'd like to see the logfiles, please.

comment:19 Changed 15 months ago by mliker

Cc: mliker removed

comment:20 Changed 14 months ago by raimue (Rainer Müller)

In e4b3d808a0739bb36c2060f8ccc52aa6b5cbbd6d/macports-ports (master):

MacVim: Add use_xcode option for MacPorts 2.6

See: #59235

comment:21 Changed 14 months ago by raimue (Rainer Müller)

Sorry for not responding earlier, but I have no macOS 10.15 Catalina and therefore cannot help with debugging of this problem.

Please test again with MacVim @8.1.snapshot161, which was just pushed to master by me.

comment:22 Changed 14 months ago by sitrucz1 (Curtis Matz)

It builds for me and works properly.

% sudo port sync && sudo port clean macvim && sudo port install macvim

--->  Updating the ports tree
--->  Cleaning MacVim
--->  Computing dependencies for MacVim
--->  Fetching archive for MacVim
--->  Attempting to fetch MacVim-8.1.snapshot161_0+huge.darwin_19.x86_64.tbz2 from https://packages.macports.org/MacVim
--->  Attempting to fetch MacVim-8.1.snapshot161_0+huge.darwin_19.x86_64.tbz2.rmd160 from https://packages.macports.org/MacVim
--->  Installing MacVim @8.1.snapshot161_0+huge
--->  Activating MacVim @8.1.snapshot161_0+huge
--->  Cleaning MacVim
--->  Updating database of binaries
--->  Scanning binaries for linking errors
--->  No broken files found.                             
--->  No broken ports found.

comment:23 Changed 14 months ago by raimue (Rainer Müller)

Resolution: fixed
Status: assignedclosed

Thank you for the confirmation!

comment:24 Changed 9 months ago by raimue (Rainer Müller)

In e4b3d808a0739bb36c2060f8ccc52aa6b5cbbd6d/macports-ports (dar, master, py38-reproject, revert-6945-rust-1.43.0, wireshark):

MacVim: Add use_xcode option for MacPorts 2.6

See: #59235

Note: See TracTickets for help on using tickets.