gnome-online-accounts @3.28.2_0: error: missing ',' between enumerators

[claws96]

relevant part of the log:

:info:build libtool: compile:  /usr/bin/clang -arch x86_64 -DHAVE_CONFIG_H -I. -I../.. -I../../src -I../../src -I../../src -I../../src -I../../src/goa -I../../src/goaidentity -
:info:build In file included from goawebview.c:27:
:info:build In file included from /opt/local/include/webkitgtk-4.0/JavaScriptCore/JavaScript.h:31:
:info:build In file included from /opt/local/include/webkitgtk-4.0/JavaScriptCore/JSContextRef.h:29:
:info:build In file included from /opt/local/include/webkitgtk-4.0/JavaScriptCore/JSObjectRef.h:31:
:info:build /opt/local/include/webkitgtk-4.0/JavaScriptCore/JSValueRef.h:54:18: error: missing ',' between enumerators
:info:build     kJSTypeSymbol JSC_API_AVAILABLE(macos(10.15), ios(13.0))
:info:build                  ^    
:info:build                  ,    
:info:build /opt/local/include/webkitgtk-4.0/JavaScriptCore/JSValueRef.h:54:36: error: expected '= constant-expression' or end of enumerator definition
:info:build     kJSTypeSymbol JSC_API_AVAILABLE(macos(10.15), ios(13.0))

Looks like the same sort of problem with compiling webkit2-gtk (which has now been fixed).

[claws96]

build log

[p-bro]

Can confirm same issue on High Sierra. Relevant log excerpt here:

:info:build libtool: compile:  /usr/bin/clang -arch x86_64 -DHAVE_CONFIG_H -I. -I../.. -I../../src -I../../src -I../../src -I../../src -I../../src/goa -I../../src/goaidentity -I../../src/goaidentity -DG_LOG_DOMAIN=\"GoaBackend\" 
-DGOA_BACKEND_COMPILATION -DGOA_API_IS_SUBJECT_TO_CHANGE -DPACKAGE_LIBEXEC_DIR=\"/opt/local/libexec\" -DPACKAGE_SYSCONF_DIR=\"/opt/local/etc\" -DPACKAGE_DATA_DIR=\"/opt/local/share/gnome-online-accounts\" -DPACKAGE_BIN_DIR=\"/opt
/local/bin\" -DPACKAGE_LOCALSTATE_DIR=\"/opt/local/var\" -DPACKAGE_LOCALE_DIR=\"/opt/local/share/locale\" -DPACKAGE_LIB_DIR=\"/opt/local/lib\" -DPACKAGE_WEB_EXTENSIONS_DIR=\"/opt/local/lib/goa-1.0/web-extensions\" -D_POSIX_PTHREA
D_SEMANTICS -D_REENTRANT -fno-strict-aliasing -I/opt/local/include -D_REENTRANT -I/opt/local/include/webkitgtk-4.0 -I/opt/local/include/gtk-3.0 -I/opt/local/include/gio-unix-2.0/ -I/opt/local/include/cairo -I/opt/local/include/pa
ngo-1.0 -I/opt/local/include/harfbuzz -I/opt/local/include/pango-1.0 -I/opt/local/include/fribidi -I/opt/local/include/atk-1.0 -I/opt/local/include/cairo -I/opt/local/include/pixman-1 -I/opt/local/include/ossp -I/opt/local/includ
e/freetype2 -I/opt/local/include/libpng16 -I/opt/local/include/gdk-pixbuf-2.0 -I/opt/local/include/libpng16 -I/opt/local/include/libsoup-2.4 -I/opt/local/include/libxml2 -I/opt/local/include/webkitgtk-4.0 -I/opt/local/include/gli
b-2.0 -I/opt/local/lib/glib-2.0/include -D_REENTRANT -I/opt/local/include/json-glib-1.0 -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -D_REENTRANT -I/opt/local/include/gio-unix-2.0/ -I/opt/local/include/glib-2.0
 -I/opt/local/lib/glib-2.0/include -D_REENTRANT -I/opt/local/include/gtk-3.0 -I/opt/local/include/gio-unix-2.0/ -I/opt/local/include/cairo -I/opt/local/include/pango-1.0 -I/opt/local/include/harfbuzz -I/opt/local/include/pango-1.
0 -I/opt/local/include/fribidi -I/opt/local/include/atk-1.0 -I/opt/local/include/cairo -I/opt/local/include/pixman-1 -I/opt/local/include/ossp -I/opt/local/include/freetype2 -I/opt/local/include/libpng16 -I/opt/local/include/gdk-
pixbuf-2.0 -I/opt/local/include/libpng16 -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -D_REENTRANT -I/opt/local/include/rest-0.7 -I/opt/local/include/libsoup-2.4 -I/opt/local/include/glib-2.0 -I/opt/local/lib/g
lib-2.0/include -I/opt/local/include/libxml2 -D_REENTRANT -I/opt/local/include/libsecret-1 -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -D_REENTRANT -I/opt/local/include/libsoup-2.4 -I/opt/local/include/libxml2
 -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include/libxml2 -D_REENTRANT -I/opt/local/include/telepathy-1.0 -I/opt/local/include/dbus-1.0 -I/opt/local/lib/dbus-1.0/include -I/opt/local/include/gl
ib-2.0 -I/opt/local/lib/glib-2.0/include -D_REENTRANT -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_gnome_gnome-online-accounts/gnome-online-accounts/work/gnome-online-a
ccounts-3.28.2/telepathy-account-widgets -I/opt/local/include/gtk-3.0 -I/opt/local/include/gio-unix-2.0/ -I/opt/local/include/cairo -I/opt/local/include/pango-1.0 -I/opt/local/include/harfbuzz -I/opt/local/include/pango-1.0 -I/op
t/local/include/fribidi -I/opt/local/include/atk-1.0 -I/opt/local/include/cairo -I/opt/local/include/pixman-1 -I/opt/local/include/ossp -I/opt/local/include/freetype2 -I/opt/local/include/libpng16 -I/opt/local/include/gdk-pixbuf-
2.0 -I/opt/local/include/libpng16 -I/opt/local/include/telepathy-1.0 -I/opt/local/include/dbus-1.0 -I/opt/local/lib/dbus-1.0/include -I/opt/local/include/libxml2 -I/opt/local/include/libsecret-1 -I/opt/local/include/glib-2.0 -I/o
pt/local/lib/glib-2.0/include -pipe -Os -arch x86_64 -MT libgoa_backend_1_0_la-nautilus-floating-bar.lo -MD -MP -MF .deps/libgoa_backend_1_0_la-nautilus-floating-bar.Tpo -c nautilus-floating-bar.c  -fno-common -DPIC -o .libs/libg
oa_backend_1_0_la-nautilus-floating-bar.o
:info:build In file included from goawebview.c:27:
:info:build In file included from /opt/local/include/webkitgtk-4.0/JavaScriptCore/JavaScript.h:31:
:info:build In file included from /opt/local/include/webkitgtk-4.0/JavaScriptCore/JSContextRef.h:29:
:info:build In file included from /opt/local/include/webkitgtk-4.0/JavaScriptCore/JSObjectRef.h:31:
:info:build /opt/local/include/webkitgtk-4.0/JavaScriptCore/JSValueRef.h:54:18: error: missing ',' between enumerators
:info:build     kJSTypeSymbol JSC_API_AVAILABLE(macos(10.15), ios(13.0))
:info:build                  ^
:info:build                  , 

By the way, this rebuild was triggered after an upgrade of the gcr depencence. I thought upgrading a dependence merits a revision bump of the dependents, but as it's broken now anyway that point is rather moot.

[p-bro]

Build log on High Sierra

[ryandesign (Ryan Carsten Schmidt)]

Duplicate #60609 suggests a possible solution (defining BUILDING_GTK__).

[nsk-dev]

Thanks to kencu (Ken) I was able to build this port after updating WEBKIT_GTK_CFLAGS in the makefiles with -DBUILDING_GTK

cd /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_gnome_gnome-online-accounts/gnome-online-accounts/work/gnome-online-accounts-3.28.2/src
./Makefile
./goabackend/Makefile
./goaidentity/Makefile
./goa/Makefile
./daemon/Makefile

[kencu (Ken)]

Hey, great.

I have pondered whether -- for our purposes on MacPorts -- we should define that by default by patching the Availabliity file ... because we are always using webkit2 on MacPorts to build GTK.

I had brought this up a couple of years ago and there were NAYs, but ... still might be the right thing to do for us.

[ken-cunningham-webuse]

In 7e6bc046da84d02d17fdb347391c4773bfe86b4f/macports-ports (master):

gnome-online-accounts: define BUILDING_GTK

pulls in webkit2-gtk headers, and without this
define, the build fails

closes: #59444