portdmg.test and portmdmg.test tests fail on Catalina

[ryandesign (Ryan Carsten Schmidt)]

​https://build.macports.org/builders/base-10.15_x86_64/builds/4/steps/test/logs/stdio

Total: 1 Passed: 0 Failed: 1 Skipped: 0  portdmg.test
> Creating disk image for fondu-060102_1


==== package_dmg Package dmg unit test. FAILED
==== Contents of test case:

    if {[portdmg::dmg_main] != 0} {
        return "FAIL: cannot create dmg"
    }
    if {![file exists $pwd/pkg/fondu-060102_1.dmg]} {
        return "FAIL: missing .dmg file"
    }
    if {![file exists $pwd/pkg/fondu-060102_1/fondu-060102_1.pkg]} {
        return "FAIL: invalid package.destpath"
    }
    return "Package dmg successful."


---- Test generated error; Return code was: 1
---- Return code should have been one of: 0 2
---- errorInfo: command execution failed
    while executing
"system "$hdiutil internet-enable -quiet -yes ${final_image}""
    (procedure "package_dmg" line 37)
    invoked from within
"package_dmg $subport $version $revision"
    (procedure "portdmg::dmg_main" line 10)
    invoked from within
"portdmg::dmg_main"
    ("uplevel" body line 2)
    invoked from within
"uplevel 1 $script"
---- errorCode: CHILDSTATUS 10115 1
==== package_dmg FAILED

Total: 1 Passed: 0 Failed: 1 Skipped: 0  portmdmg.test


==== package_mdmg Package mdmg unit test. FAILED
==== Contents of test case:

    if {[portmdmg::package_mdmg $subport $version $revision] != 0} {
        return "FAIL: cannot create mdmg"
    }
    if {![file exists $pwd/pkg/fondu-060102_1.dmg]} {
        return "FAIL: missing .dmg file"
    }
    if {![file exists $pwd/pkg/fondu-060102_1/fondu-060102_1.mpkg]} {
        return "FAIL: invalid package.destpath"
    }
    return "Package dmg successful."


---- Test generated error; Return code was: 1
---- Return code should have been one of: 0 2
---- errorInfo: command execution failed
    while executing
"system "$hdiutil internet-enable -quiet -yes ${final_image}""
    (procedure "portmdmg::package_mdmg" line 37)
    invoked from within
"portmdmg::package_mdmg $subport $version $revision"
    ("uplevel" body line 2)
    invoked from within
"uplevel 1 $script"
---- errorCode: CHILDSTATUS 10142 1
==== package_mdmg FAILED

[kurthindenburg (Kurt Hindenburg)]

from man hdiutil:

     macOS 10.15:

           o   Removed the deprecated "hdiutil internet-enable" command and
               the IDME attach flags.

This is why the dmg fails to get build in 10.15

hdiutil: internet-enable: verb not recognized

[kurthindenburg (Kurt Hindenburg)]

The test sets:

set os.major 10

so I can't check that. What's the reason for setting that in a test?

This should be a simple 'if {${os.major} < 19}' then do the internet-enable command.

[jmroot (Joshua Root)]

In 0459cb14ac20e26d20a87e71e3d3390ee541ae8b/macports-base (master):

Don't try to internet-enable dmgs on 10.15+

Closes: #59697

[jmroot (Joshua Root)]

In f92aa5940657a6958066a4c512a82eb50c48b2a5/macports-base (master):

Use real os.major and os.arch in (m)dmg tests

Closes: #59697