olm is not using the right compiler or flags

[ryandesign (Ryan Carsten Schmidt)]

olm is not UsingTheRightCompiler, nor do I see the -stdlib= flag nor -arch flags:

​https://build.macports.org/builders/ports-10.6_i386-builder/builds/4612/steps/install-port/logs/stdio

make: Entering directory `/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_devel_olm/olm/work/olm-2.3.0'
mkdir -p build/release/src/
mkdir -p build/release/src/
mkdir -p build/release/src/
mkdir -p build/release/src/
g++ -Wall -Werror -std=c++11 -fPIC -g -O3 -Iinclude -Ilib -DOLMLIB_VERSION_MAJOR=2 -DOLMLIB_VERSION_MINOR=3 -DOLMLIB_VERSION_PATCH=0 -MMD  -c -o build/release/src/base64.o src/base64.cpp
g++ -Wall -Werror -std=c++11 -fPIC -g -O3 -Iinclude -Ilib -DOLMLIB_VERSION_MAJOR=2 -DOLMLIB_VERSION_MINOR=3 -DOLMLIB_VERSION_PATCH=0 -MMD  -c -o build/release/src/crypto.o src/crypto.cpp
g++ -Wall -Werror -std=c++11 -fPIC -g -O3 -Iinclude -Ilib -DOLMLIB_VERSION_MAJOR=2 -DOLMLIB_VERSION_MINOR=3 -DOLMLIB_VERSION_PATCH=0 -MMD  -c -o build/release/src/cipher.o src/cipher.cpp
g++ -Wall -Werror -std=c++11 -fPIC -g -O3 -Iinclude -Ilib -DOLMLIB_VERSION_MAJOR=2 -DOLMLIB_VERSION_MINOR=3 -DOLMLIB_VERSION_PATCH=0 -MMD  -c -o build/release/src/account.o src/account.cpp
cc1plus: error: unrecognized command line option "-std=c++11"cc1plus: error: unrecognized command line option "-std=c++11"

cc1plus: error: unrecognized command line option "-std=c++11"
cc1plus: error: unrecognized command line option "-std=c++11"

Since this port uses use_configure no, it falls to the port maintainer to manually implement the functionality that MacPorts base gives you for free when you do have a configure script.

[kencu (Ken)]

The ports that depend on this library need work, they don't build at present, some of them are archived and dormant now, others have moved on to new projects.

It's conceivable that this library and all the ports that depend on it might just be deleted now, therefore, but I will leave that to someone who uses it to decide.

this updates to the latest version, changes to the recommended cmake build (which fixes the use_configure no problem) and enables the tests (all of which pass)...

[kencu (Ken)]

that portfile patch also installs the dylib rather than the static lib. That can be changed with a configure arg if the static lib is truly desired.

The ports that use olm currently use the static lib, so they would have to be updated...but see above re updating them....

[scarface-one (Sireesh Kodali)]

I've created a PR for this: ​https://github.com/macports/macports-ports/pull/5896

As for the ports that depend on OLM, right now I've added a static variant which creates a static lib, but I think removing the ports with no updates makes sense (nheko, mtxclient).

[Sireesh Kodali <22617812+scarface-one@…>]

In 253f6d8f15de8a623e8c01c847a6815b60bb6d5c/macports-ports (master):

olm: update to v3.1.4

• update to 3.1.4
• use cmake for build system, as make is now deprecated
• added variant static for any ports which need static lib
• fixed build failure

Closes: #59760