libjpeg-turbo @2.0.3+universal: Undefined symbols for architecture x86_64

[Cor0n4V1rus]

judging from the build log, maybe it's because the cmake execution is not correct for a +universal build, despite the -DCMAKE_OSX_ARCHITECTURES="x86_64;i386" parameter:

...
32-bit build (i386)
...
CMAKE_ASM_NASM_OBJECT_FORMAT = macho
CMAKE_ASM_NASM_FLAGS = -DMACHO -DPIC
SIMD extensions: i386 (WITH_SIMD = 1)

files containing the functions the linker cannot find are compiled with nasm with the '-f macho' option, therefore i386-only.

"nasm -hf" states:

...
valid output formats for -f are (`*' denotes default):
...
macho32 NeXTstep/OpenStep/Rhapsody/Darwin/MacOS X (i386) object files
macho64 NeXTstep/OpenStep/Rhapsody/Darwin/MacOS X (x86_64) object files
...
macho MACHO (short name for MACHO32)
...

the used nasm is the one from macports:

/opt/local/bin/nasm -v
NASM version 2.14.02 compiled on Jan 27 2020

a quick test, compiling the first file "jsimdcpu.asm" with nasm and

"-f macho32 -f macho64"

showed, that only the last -f option is used, therefore only one architecture per compilation unit possible. maybe, for +universal, the whole project has to be compiled twice and then merged with lipo!?

[ryandesign (Ryan Carsten Schmidt)]

Replying to Cor0n4V1rus:

maybe, for +universal, the whole project has to be compiled twice and then merged with lipo!?

That would happen if the Portfile used "PortGroup muniversal 1.0", but it currently doesn't.

[JDLH (Jim DeLaHunt)]

I am experiencing this bug, attempting to upgrade port tiff @4.2.0_0+universal1 to @4.2.0_1, which in turn rebuilds libjpeg-turbo-2.0.4_0+universal. I am using MacPorts version 2.6.4 on macOS 10.13.6 High Sierra.

[jmroot (Joshua Root)]

A couple of things to try:

• 2.0.6 update: ​https://github.com/macports/macports-ports/pull/9760
• Try disabling use of nasm when building universal? That could be accomplished by making this change (diff against the 2.0.6 Portfile):

  graphics/libjpeg-turbo/Portfile

  @@ -32 +32 @@
                       sha256  d74b92ac33b0e3657123ddcf6728788c90dc84dcb6a52013d758af3c4af481bb \
                       size    2192315
   
  -if {${build_arch} in {i386 x86_64} || ([variant_isset universal] &&
  -    ("x86_64" in ${universal_archs} || "i386" in ${universal_archs}))} {
  +if {${build_arch} in {i386 x86_64} && ![variant_isset universal]} {
   depends_build-append port:nasm
   
   configure.env       ASM_NASM=${prefix}/bin/nasm

If all else fails, we'll just have to enable muniversal.

[JDLH (Jim DeLaHunt)]

GZip compressed archive of /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_graphics_libjpeg-turbo/libjpeg-turbo/main.log for @2.0.4_0+universal

[JDLH (Jim DeLaHunt)]

Replying to jmroot:

A couple of things to try:

• 2.0.6 update: ​https://github.com/macports/macports-ports/pull/9760
• Try disabling use of nasm when building universal?

… [snip] …

Thank you for the suggestions, @jmroot. I'll give them a try in a day or two, and report back.

[metbic]

How come this bug lounged around for like a year, with no one else bothering, and then, all of a sudden, emerges?

[mascguy (Christopher Nielsen)]

Replying to metbic:

How come this bug lounged around for like a year, with no one else bothering, and then, all of a sudden, emerges?

Until today, libjpeg-turbo wasn't utilized. Now that it's in play, we're all rallying to quickly fix these issues.

[kencu (Ken)]

I put a fix for the x86_64/arm64 universal build, at least, in Josh's PR <​https://github.com/macports/macports-ports/pull/9760>

% port -v installed libjpeg-turbo
The following ports are currently installed:
  libjpeg-turbo @2.0.6_0+universal (active) platform='darwin 20' archs='arm64 x86_64' date='2021-01-18T17:50:56-0800'

so far, I have only built this universal on an Intel system.

[jmroot (Joshua Root)]

In 5ccfa6cbaf125e31115eca5a871c84045d5f0b5f/macports-ports (master):

libjpeg-turbo: use muniversal

Fixes: #60018

[MaddTheSane (C.W. Betts)]

I'm still having issues building the universal version on arm64. It's trying to build jsimd_neon.S as a universal arm64 and x86_64 assembly file.

Maybe we do need to configure this port in separate directories then lipo it together, or the MacPorts rsync server hasn't been updated yet.

edit: looks like rsync hasn't updated. Ignore.

[JDLH (Jim DeLaHunt)]

libjpeg-turbo @2.0.6_0+universal built successfully. Then tiff @4.2.0_1+universal, which depends on it, built successfully. This on the MacPorts version 2.6.4 on macOS 10.13.6 High Sierra, on which it failed earlier today per comment:4 . A couple dozen ports are now lined up to rebuild. Thank you for the fix!