fontforge @20190801_2 fails building on 10.5.8 PPC

[udbraumann]

While upgrading fontforge from 20170731_0 to 20190801_2, after long time building fails here:

...
:info:build libtool: compile:  /opt/local/bin/gcc-mp-7 -DHAVE_CONFIG_H -I. -I../inc -I../inc -I../inc -I../lib -I../lib -I../fontforge -DSHAREDIR=\"/opt/local/share/fontforge\" -DDO
CDIR=\"/opt/local/share/doc/fontforge\" -Werror=implicit-function-declaration -Werror=int-conversion -D_REENTRANT -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -D_
REENTRANT -I/opt/local/include/gtk-3.0 -I/opt/local/include/gio-unix-2.0/ -I/opt/local/include/cairo -I/opt/local/include/pango-1.0 -I/opt/local/include/harfbuzz -I/opt/local/includ
e/pango-1.0 -I/opt/local/include/fribidi -I/opt/local/include/gdk-pixbuf-2.0 -I/opt/local/include/cairo -I/opt/local/include/pixman-1 -I/opt/local/include/ossp -I/opt/local/include/
freetype2 -I/opt/local/include/libpng16 -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include/pango-1.0 -I/opt/local/include/harfbuzz -I/opt/local/inc
lude/pango-1.0 -I/opt/local/include/fribidi -I/opt/local/include/cairo -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include/pixman-1 -I/opt/local/inc
lude/ossp -I/opt/local/include/freetype2 -I/opt/local/include/libpng16 -I/opt/local/include/freetype2 -I/opt/local/include/libpng16 -I/opt/local/include/libxml2 -I/opt/local/Library
/Frameworks/Python.framework/Versions/3.8/include/python3.8 -pthread -I/ -I/opt/local/include -I.. -I.. -pipe -Os -std=gnu11 -arch ppc -MT libfontforgeexe_la-startui.lo -MD -MP -MF
.deps/libfontforgeexe_la-startui.Tpo -c startui.c  -fno-common -DPIC -o .libs/libfontforgeexe_la-startui.o
:info:build startui.c:70:17: error: two or more data types in declaration specifiers
:info:build  #define SRefCon long
:info:build                  ^
:info:build make[3]: *** [libfontforgeexe_la-startui.lo] Error 1
...

To me this error message remains cryptic, what "two or more data types"? Any ideas?

[kencu (Ken)]

This is coming in from my patch that replaces SRefCon [0501b5b95cf57c43a4b18c0c73639626b2fc24b8/macports-ports] which used to work, but I guess doesn't now. I'll have to see.

[udbraumann]

Thanks for that remark, apparently when you made the patch, fontforge was @20190801_0, I am pretty sure that version fontforge @20190801_1 already failed during building at the same point, but since a month or so version is @20190801_2. Perhaps you find some time to look at this SRefCon issue again.

[udbraumann]

Replying to kencu:

This is coming in from my patch that replaces SRefCon [0501b5b95cf57c43a4b18c0c73639626b2fc24b8/macports-ports] which used to work, but I guess doesn't now. I'll have to see.

Instead of these lines in your patch

+/* replace missing def on older MacOS systems */
+#ifndef SRefCon
+#define SRefCon long
+#endif

I suggest to use

+/* replace missing def on older MacOS systems */
+#ifndef SRefCon
+typedef long SRefCon;
+#endif

Using the latter, the "error: two or more data types in declaration specifiers" has gone on my 10.5.8 G4 PPC.

I feel this is a kind of hack, perhaps someone else has a better idea.

[evanmiller (Evan Miller)]

SRefCon is defined in MacTypes.h in the 10.5 headers, so the definition should only be needed on 10.4 anyway. See here

​https://github.com/phracker/MacOSX-SDKs/blob/10dd4868459aed5c4e6a0f8c9db51e20a5677a6b/MacOSX10.5.sdk/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/Headers/MacTypes.h#L320

[evanmiller (Evan Miller)]

In 566e206bbd721a4c57a9ba0acdf6d8e0ba828174/macports-ports (master):

fontforge: update to 20201107

See: #60409

[barracuda156]

Now even the patch fails to apply.

[ryandesign (Ryan Carsten Schmidt)]

When updating fontforge to 20230101 I removed the patches because the code they were patching was ​removed in 2021 when the project switched from Carbon event handlers to Cocoa event handlers, but it did so in a way that ​requires the modern Objective-C runtime which is not available for 32-bit.

[ryandesign (Ryan Carsten Schmidt)]

In 7be8b592431b8736dabdf67295d989146e3b7fdc/macports-ports (master):

fontforge: Requires modern Objective-C runtime

Closes: #60409

[barracuda156]

Replying to ryandesign:

In 7be8b592431b8736dabdf67295d989146e3b7fdc/macports-ports (master):

fontforge: Requires modern Objective-C runtime

Closes: #60409

I guess a better fix will be to restore an older version for 32-bit platforms. Maybe wait for upstream reply a bit, if nothing, then add back an older version.

[barracuda156]

In 3dfe70e1a4986dfd1e21e700380e0f20e62dce9a/macports-ports (master):

fontforge: provide version for 32-bit and old OS

A proper fix for #60409