Opened 8 days ago

Last modified 12 hours ago

#60518 assigned defect

mpv 0.32.0

Reported by: dardo82 (Michele Venturi) Owned by: Ionic (Mihai Moldovan)
Priority: Normal Milestone:
Component: ports Version: 2.6.2
Keywords: highsierra Cc: dardo82 (Michele Venturi)
Port: mpv

Description (last modified by mf2k (Frank Schima))

0.32.0 doesn't work with --disable-swift


https://github.com/mpv-player/mpv/issues/7449

"cocoa-cb backend requires Swift 5 or 4 support, which is only available in Xcode 9.1 onwards."
No, Command Line Tools will suffice; it works commenting out the subsequent conditional statement.
changeset:968496de4d39c0a8c65e3a306e14e6886827ac2a/macports-ports


Configuration: ./waf configure --prefix=/opt/local --enable-manpage-build --enable-libass --enable-coreaudio --enable-cocoa --enable-cplugins --enable-zlib --enable-swift --disable-html-build --disable-cuda-hwaccel --disable-opensles --disable-egl-drm --disable-egl-angle-lib --disable-egl-angle-win32 --disable-audiounit --disable-ios-gl --disable-direct3d --disable-android --disable-rpi --disable-dvbin --disable-pdf-build --disable-test --disable-clang-database --disable-debug-build --disable-libsmbclient --enable-dvdnav --enable-cdda --disable-vapoursynth --enable-libarchive --enable-rubberband --disable-pulse --disable-jack --disable-openal --enable-gl-cocoa --disable-x11 --disable-xv --disable-gl-x11 --disable-egl-x11 --disable-caca --disable-jpeg --disable-tv --enable-gl --disable-javascript --disable-uchardet --enable-videotoolbox-gl --enable-lua --lua=52fbsd --enable-libass-osd



[cplayer] List of enabled features: 52fbsd asm atomics bsd-fstatfs build-date cdda cocoa coreaudio cplayer cplugins drmprime dvdnav fchmod ffmpeg gl gl-cocoa glob glob-posix gnuc gpl iconv lcms2 libarchive libass libass-osd libav-any libavcodec libavdevice libavutil libbluray libdl libm lua macos-10-11-features macos-10-12-2-features macos-10-14-features macos-cocoa-cb macos-media-player macos-touchbar optimize osx-thread-name posix posix-or-mingw posix-spawn posix-spawn-native pthreads rubberband stdatomic videotoolbox-gl videotoolbox-hwaccel zlib

Attachments (1)

Portfile (20.4 KB) - added by dardo82 (Michele Venturi) 8 days ago.
fixed port file

Download all attachments as: .zip

Change History (16)

Changed 8 days ago by dardo82 (Michele Venturi)

Attachment: Portfile added

fixed port file

comment:1 Changed 8 days ago by mf2k (Frank Schima)

In the future, please use WikiFormatting and add the port maintainer(s) to Cc (port info --maintainers mpv), if any.

comment:2 Changed 8 days ago by mf2k (Frank Schima)

Also, the Milestone field is for use by Macports team members only, please do not set it.

comment:3 Changed 8 days ago by mf2k (Frank Schima)

Milestone: MacPorts 2.6.3
Owner: set to Ionic
Status: newassigned

comment:4 Changed 8 days ago by mf2k (Frank Schima)

Description: modified (diff)

comment:5 Changed 8 days ago by mf2k (Frank Schima)

Thanks for the suggested fix. Per the guidelines, please instead attach a unified diff of the Portfile so we can easily see what changes you are proposing. Or better yet, submit a GitHub pull request.

comment:6 Changed 8 days ago by kencu (Ken)

Or just wait a bit -- there are multiple floating tickets about mpv, and I've nearly got it done:

<https://github.com/kencu/macports-ports/commits/mpvoldersystemsfix>

comment:7 Changed 8 days ago by dardo82 (Michele Venturi)

Thanks for the quick reply, couldn't wait as it stopped working as stated above,but can I install it from your branch? Furthermore this nearly the first time I try to do this,I'm not yet familiar with the best practices; I've tried to use some formatting as you can see,but maybe it was wrong...

Last edited 8 days ago by dardo82 (Michele Venturi) (previous) (diff)

comment:8 in reply to:  7 Changed 8 days ago by dardo82 (Michele Venturi)

How I delete a mistake here?

Last edited 8 days ago by dardo82 (Michele Venturi) (previous) (diff)

comment:9 Changed 7 days ago by kencu (Ken)

Here is a PR that fixes the mpv build on 10.7 to 10.10; 10.11+ seem fine at present.

<https://github.com/macports/macports-ports/pull/7153>

I'll take a look at 10.4 to 10.6 later on.

comment:10 in reply to:  9 Changed 7 days ago by dardo82 (Michele Venturi)

Replying to kencu:

Here is a PR that fixes the mpv build on 10.7 to 10.10; 10.11+ seem fine at present.

<https://github.com/macports/macports-ports/pull/7153>

I'll take a look at 10.4 to 10.6 later on.

HAVE YOU EVEN TRIED TO USE IT ON 10.13?
HAVE YOU READ WHAT I'VE WRITTEN?
I'M I WASTING MY TIME?
It builds but doesn't work!

This is exactly why I don't wait:
you can't trust people
with making their job right.

And you are not going to get much help
disregarding whatn newcomers tells you!

Last edited 7 days ago by dardo82 (Michele Venturi) (previous) (diff)

comment:11 in reply to:  7 Changed 7 days ago by kencu (Ken)

I will leave mpv to others. PR closed.

comment:12 Changed 6 days ago by dardo82 (Michele Venturi)

That is actually a good decision, you don't seem up for the task.

comment:13 in reply to:  12 Changed 15 hours ago by neverpanic (Clemens Lang)

Replying to dardo82:

HAVE YOU EVEN TRIED TO USE IT ON 10.13?
HAVE YOU READ WHAT I'VE WRITTEN?
I'M I WASTING MY TIME?
It builds but doesn't work!

This is exactly why I don't wait:
you can't trust people
with making their job right.

And you are not going to get much help
disregarding whatn newcomers tells you!

Replying to dardo82:

That is actually a good decision, you don't seem up for the task.

Regardless of whether this is technically correct or not, this attitude is uncalled for in a project where people invest their free time.

Please refrain from such insults in the future.

comment:14 Changed 15 hours ago by neverpanic (Clemens Lang)

Also to be honest, from your ticket description, I can't figure out what you actually want to do (I guess I'm "not up for the task" either…), you didn't attach a unified diff like you were asked to in comment:5, and you don't seem to have opened a pull request either.

comment:15 Changed 13 hours ago by kencu (Ken)

Although I also found this ticket indecipherable, the upstream issue links to an upstream bug that has been fixed here in this commit <https://github.com/mpv-player/mpv/commit/188169854313b99d01da8f69fe129f0a487eb7c4>.

So feel free to help this fellow out -- as I am just not up to the task.

Last edited 12 hours ago by kencu (Ken) (previous) (diff)
Note: See TracTickets for help on using tickets.