xxhashlib @0.7.3_2 does not build with gcc-4.2 because cc1: error: unrecognized command line option "-Wvla"

[ballapete (Peter "Pete" Dyballa)]

Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_devel_xxhash/xxhashlib/work/xxhash-0.7.3" && /usr/bin/make -w all CC="/usr/bin/gcc-4.2" CXX="/usr/bin/g++-4.2" OBJC="/usr/bin/gcc-4.2" OBJCXX="/usr/bin/g++-4.2" INSTALL="/usr/bin/install -c" 
DEBUG: system:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_devel_xxhash/xxhashlib/work/xxhash-0.7.3" && /usr/bin/make -w all CC="/usr/bin/gcc-4.2" CXX="/usr/bin/g++-4.2" OBJC="/usr/bin/gcc-4.2" OBJCXX="/usr/bin/g++-4.2" INSTALL="/usr/bin/install -c" 
make: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_devel_xxhash/xxhashlib/work/Cyan4973-xxHash-d408e9b'
/usr/bin/gcc-4.2 -Os -arch ppc -Wall -Wextra -Wconversion -Wcast-qual -Wcast-align -Wshadow -Wstrict-aliasing=1 -Wswitch-enum -Wdeclaration-after-statement -Wstrict-prototypes -Wundef -Wpointer-arith -Wformat-security -Wvla -Wformat=2 -Winit-self -Wfloat-equal -Wwrite-strings -Wredundant-decls -Wstrict-overflow=2 -I/opt/local/include  -c xxhash.c -o xxhash.o
cc1: error: unrecognized command line option "-Wvla"
make: *** [xxhash.o] Error 1
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_devel_xxhash/xxhashlib/work/Cyan4973-xxHash-d408e9b'
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_tarballs_ports_devel_xxhash/xxhashlib/work/xxhash-0.7.3" && /usr/bin/make -w all CC="/usr/bin/gcc-4.2" CXX="/usr/bin/g++-4.2" OBJC="/usr/bin/gcc-4.2" OBJCXX="/usr/bin/g++-4.2" INSTALL="/usr/bin/install -c" 
Exit code: 2
Error: Failed to build xxhashlib: command execution failed

[ballapete (Peter "Pete" Dyballa)]

Main.log from PPC Leopard

[ballapete (Peter "Pete" Dyballa)]

This patch removes the faulty -Wvla option from Makefile.

[ballapete (Peter "Pete" Dyballa)]

Patch to remove '-Wvla'

[Schamschula (Marius Schamschula)]

In e836eb789e8c26c06deb4085eeb96d60840697ff/macports-ports (master):

xxhash: fix Leopard build issue

Closes: #60710

[ballapete (Peter "Pete" Dyballa)]

The same failure happens on PPC Tiger, Mac OS X 10.4.11. And it has the same cure.

[kencu (Ken)]

also happens any time gcc-4.2 (at least) tries to build this on any system. Ideally we might test for that compiler I guess. Web says gcc-4.8 accepts this, not sure where cutoff is between them.