mbedtls @2.23.0: error: will never be executed [-Werror,-Wunreachable-code]

[ryandesign (Ryan Carsten Schmidt)]

​https://build.macports.org/builders/ports-10.8_x86_64-builder/builds/20787/steps/install-port/logs/stdio

/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_devel_mbedtls/mbedtls/work/mbedtls-2.23.0/library/bignum.c:814:13: error: will never be executed [-Werror,-Wunreachable-code]
    return( mpi_uint_bigendian_to_host_c( x ) );
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_devel_mbedtls/mbedtls/work/mbedtls-2.23.0/library/bignum.c:804:21: error: will never be executed [-Werror,-Wunreachable-code]
            return( __builtin_bswap32(x) );
                    ^~~~~~~~~~~~~~~~~
2 errors generated.

Maybe don't use -Werror.

[ryandesign (Ryan Carsten Schmidt)]

Manifests a different way on 10.7:

​https://build.macports.org/builders/ports-10.7_x86_64-builder/builds/25697/steps/install-port/logs/stdio

/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_devel_mbedtls/mbedtls/work/mbedtls-2.23.0/include/mbedtls/aes.h:190:5: error: duplicated command '\return' [-Werror,-Wdocumentation]
 * \return         #MBEDTLS_ERR_AES_INVALID_KEY_LENGTH on failure.
   ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[Schamschula (Marius Schamschula)]

In 04c9b2d7e79e7bf1a9d54430977dde1fb13aa1ad/macports-ports (master):

mbedtls: attempt to fix Werror issue

See: #60762

[ryandesign (Ryan Carsten Schmidt)]

Thanks... Looks like the next problem is:

/usr/bin/ranlib -no_warning_for_no_symbols -c libmbedcrypto.a
error: /usr/bin/ranlib: unknown option character `n' in: -no_warning_for_no_symbols

Could add a dependency on port:cctools for 10.8 and earlier to get a newer ranlib.

[Schamschula (Marius Schamschula)]

In 3d59f47eed7a4a3794ff447d62ab9cb839b34039/macports-ports (master):

mbedtls: continue trying to fix build on older macOS versions

See: #60762

[Schamschula (Marius Schamschula)]

Well, using cctools didn't help.

[ryandesign (Ryan Carsten Schmidt)]

In 9c3080dc61cd631612dbd0c263e48aaf7b29e92a/macports-ports (master):

mbedtls: Use MacPorts ranlib on 10.8 and earlier

Closes: #60762