Opened 4 years ago

Closed 4 years ago

#61007 closed update (invalid)

Lua @ 5.4.0 Update - Need help on defining what counts as Subport vs Port (standalone)

Reported by: pekdemira (Alper Pekdemir) Owned by:
Priority: Normal Milestone:
Component: ports Version: 2.6.3
Keywords: Cc:
Port: Lua

Description

Updated the Lua port to 5.4.0 and about create a PR after a successful build. However, I have other questions since I noticed subports in the Portfile vs existing ports in the tree for older versions.

This port is getting updated from 5.3.x to 5.4.x. There was a subport defined in the Portfile for 5.2.x with a note saying "add versions 5.1 as subports". Then we have lua50, lua51, lua52 as dedicated ports.

I am basically trying to get a clarification on what counts as a subport and what counts as a standalone port given the versions of a piece of software. How do we determine when to use subport and when to create a new port for a new version.

For example nodejs doesn't have subports and have dedicated ports in tree as: nodejs13, nodejs12, etc. I feel like Lua would follow the same pattern. Is there a defined strategy? Any pointers would be great, I can try tidying up the port accordingly.

I looked for documentation for subports but couldn't find any. There were couple tickets asking the same question. I can go ahead and try updating the guide trying to put together definitions as well.

Thank you,

Change History (3)

comment:1 Changed 4 years ago by jmroot (Joshua Root)

If using subports makes maintaining the ports easier, use them. If it makes it harder, don't.

comment:2 Changed 4 years ago by pekdemira (Alper Pekdemir)

I was wondering if there was a defining factor concerning end user usability, or type of software (library, core, etc.). From my understanding the convenience is the defining factor.

Please feel free to close this ticket. I think it is best to keep the conversation in one location (over Github) as Mojca suggested.

Thank you,

comment:3 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: invalid
Status: newclosed

From the standpoint of the end user, the way they interact with the port is identical whether the port is a standalone portfile or a subport in another portfile. The user doesn't even really need to know which it is. (Any subports of the "main" port are displayed in port info; that's probably the only user-visible difference.) Subports are a convenience for the portfile developer / maintainer so that large portions of similar code don't need to be duplicated in multiple portfiles.

Note: See TracTickets for help on using tickets.