libVLC @3.0.11: error: expected a type

[ryandesign (Ryan Carsten Schmidt)]

libVLC fails to build:

​https://build.macports.org/builders/ports-10.12_x86_64-builder/builds/125477/steps/install-port/logs/stdio

access/avaudiocapture.m:51:36: error: expected a type
+ (void)requestAccessForMediaType:(AVMediaType)mediaType completionHandler:(void (^)(BOOL granted))handler API_AVAILABLE(macos(10.14), ios(7.0));
                                   ^
1 error generated.

[RJVB (René Bertin)]

This is becoming way too complicated to maintain, with upstream dropping all support for building on older OS versions.

Remind me again why the port had to be updated to 3.0.11 please?

[ryandesign (Ryan Carsten Schmidt)]

You updated it...

[RJVB (René Bertin)]

Well, doh ... but why did I do that? Certainly not for the fun of it.

[kencu (Ken)]

60667

[RJVB (René Bertin)]

Hmm, could we just roll back to 3.0.8 in hope that whatever issues that version had can be addressed more easily?

[RJVB (René Bertin)]

OK, so it looks like most of the remaining failures *could* be a simple result of building with too old a compiler. I have added a few tweaks that should avoid this, what's the best way to check this? Given the previous experience with the PR-related test builds I just as rather avoid those and have someone do a test build on 10.13 or earlier (as far as I can tell, only the Qt4 version of the phonon VLC backend fails on 10.14 and up).

[kencu (Ken)]

I'd be happy to help. is the WIP in your github tree?

[RJVB (René Bertin)]

Thanks Ken. Yes, I pushed the changes to my repo. My version evidently has a few additional convience tweaks but they should be transparent (=disabled) if you build from inside the portdir (instead of adding the entire tree as a source).