Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#61127 closed defect (fixed)

spdlog update broke aff4

Reported by: chrstphrchvz (Christopher Chavez) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.6.3
Keywords: Cc: XNephila (X Nephila), ghosthound
Port: aff4 spdlog

Description

It was observed in 2018 that updating spdlog to ≥ 1.0 would break aff4 (see [85b10ef0f8/macports-ports] and https://github.com/Velocidex/c-aff4/issues/38). This knowledge never made it to a comment in the spdlog portfile or a ticket where it would be easily noticed when someone tried updating it. spdlog has since been updated from 0.16.3 to 1.4.2 ([bb7d7b7b6d/macports-ports]) and then 1.5.0 ([7caf3d34e5/macports-ports]), and as expected aff4 currently fails to build:

libaff4.cc:536:24: error: no member named 'stderr_color_mt' in namespace 'spdlog'
        return spdlog::stderr_color_mt("aff4");
               ~~~~~~~~^
1 error generated.

Change History (2)

comment:1 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: set to ryandesign
Resolution: fixed
Status: newclosed

In 05ab953b1a432450aa9d00805b08db9ded4902ee/macports-ports (master):

aff4: Build using spdlog0

Closes: #61127

Also use compiler.cxx_standard instead of cxx11 1.1 portgroup.

comment:2 Changed 4 years ago by ghosthound

All good, and thanks for the creating/reopening the c-aff4 ticket (https://github.com/Velocidex/c-aff4/issues/38) as well.

Note: See TracTickets for help on using tickets.