unbound @1.12.0: error: use of undeclared identifier 'IF_NAMESIZE'

[chrstphrchvz (Christopher Chavez)]

Build fails on ​10.8 and earlier:

services/listen_dnsport.c:1411:40: error: use of undeclared identifier 'IF_NAMESIZE'
                char addr_buf[INET6_ADDRSTRLEN + 1 + IF_NAMESIZE + 1 + 16 + 1];
                                                     ^
services/listen_dnsport.c:1447:23: error: use of undeclared identifier 'IF_NAMESIZE'
                        char if_index_name[IF_NAMESIZE + 1];
                                           ^
services/listen_dnsport.c:1453:4: warning: implicit declaration of function 'if_indextoname' is invalid in C99 [-Wimplicit-function-declaration]
                        if_indextoname(in6->sin6_scope_id,
                        ^
1 warning and 2 errors generated.

This is because during configuration net/if.h (which defines IF_NAMESIZE) isn't detected, so HAVE_NET_IF_H isn't defined and net/if.h won't be included by source files:

checking for net/if.h... no

Without digging into the configuration check, I'm inclined to think this is similar to #55238 where sys/socket.h needs to be included when using net/if.h on 10.8 and earlier; a future release of legacysupport will include sys/socket.h automatically ([ea4b467559/macports-legacy-support]).

[jmroot (Joshua Root)]

Even on current systems, the man page for if_indextoname specifies multiple includes in the synopsis:

     #include <sys/types.h>
     #include <sys/socket.h>
     #include <net/if.h>

Should probably split net/if.h into its own AC_CHECK_HEADERS with an additional sys/socket.h conditional include on top of the ones in AC_INCLUDES_DEFAULT.

[jmroot (Joshua Root)]

The autoconf manual even has an example for this: ​https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Header-Portability.html

[kencu (Ken)]

the current release of legacy-support has the net/if.h fix in it.

[iefdev (Eric F)]

This got it to work for me. Don't know if the names are the same on all versions though.

services/listen_dnsport.c

@@ -71 +71 @@
 #include <systemd/sd-daemon.h>
 #endif
 
+#if __APPLE__
+  #define HAVE_IFADDRS_H _IFADDRS_H_
+  #define HAVE_NET_IF_H _NET_IF_H_
+#endif
+
 #ifdef HAVE_IFADDRS_H
 #include <ifaddrs.h>
 #endif

[iefdev (Eric F)]

If it's <= 10.8, I should prob use: #if MAC_OS_X_VERSION_MAX_ALLOWED <= 1080 instead.

[kencu (Ken)]

or instead of all this - pretty sure - just add legacysupport and you're done, I think. Haven't tried it, tho.

[iefdev (Eric F)]

Replying to kencu:

or instead of all this - pretty sure - just add legacysupport and you're done, I think. Haven't tried it, tho.

Both 1.0 and 1.1 worked… Go with legacysupport 1.1?

[nerdling (Jeremy Lavergne)]

chrstphrchvz also has a PR for 10.8 issues around undefined symbols: will the portgroup addition meld well with those changes?

​https://github.com/macports/macports-ports/pull/8776/files

[nerdling (Jeremy Lavergne)]

Replying to nerdling: Whoops, mixing up Ports.

[kencu (Ken)]

Replying to iefdev:

Go with legacysupport 1.1?

that's what I would do, but it's the perennial practical vs. purity argument, and I always come down on the side of practical.

[iefdev (Eric F)]

Replying to kencu:

Replying to iefdev:

Go with legacysupport 1.1?

that's what I would do, but it's the perennial practical vs. purity argument, and I always come down on the side of practical.

I went with that:

$ port -v installed unbound
The following ports are currently installed:
  unbound @1.12.0_1+nghttp2-universal (active) platform='darwin 11' archs='x86_64' date='2020-10-14T19:54:27+0200'

[jmroot (Joshua Root)]

In 566bb98308935e4e8203b6a40eed052ab64de675/macports-ports (master):

unbound: fix check for net/if.h

Closes: #61314

[iefdev (Eric F)]

In 3abb85caeb7d15ab40f97b56fab8737500e0aad5/macports-ports (master):

unbound: add variant nghttp2 (DoH)

New in 1.12.0 is DoH. To use it, nghttp2 is needed.

• add variant: +nghttp2
• add depends_lib: nghttp2

Also:

• add PortGroup legacysupport 1.1
• Closes: #61314