samba4 @4.13.1: installed files link with libraries in build directory

[ryandesign (Ryan Carsten Schmidt)]

Nothing installed by the samba4 port works because it links with libraries that were in the build directory, which no longer exists after the installation finishes.

$ smbget4
/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_net_samba4/samba4/work/samba-4.13.1/bin/default/source3/libsmb/libsmbclient.dylib
  Referenced from: /opt/local/bin/smbget4
  Reason: image not found
Abort trap: 6

$ smbd4
/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_net_samba4/samba4/work/samba-4.13.1/bin/default/source3/libpopt-samba3-samba4.dylib
  Referenced from: /opt/local/sbin/smbd4
  Reason: image not found
Abort trap: 6

[21stcaveman (Hamid Maadani)]

This was expected. I was planning to open a trac ticket myself, and then submit a commit for it. The reason for that, is I am copying this entirely from macstrop repo (​https://github.com/RJVB/macstrop), and all the work is done by Rene. I will copy him on this ticket.

I have submitted ​pull request 8986 to address this.

testing samba4 on my macbook, using the above commit, this is what I get :

$ /opt/local/bin/smbget 
Downloaded 0b in 0 seconds`

$ sudo /opt/local/bin/smbstatus 
Samba version 4.13.0
...

[scottschreckengaust (Scott Schreckengaust)]

port -d -y rev-upgrade

[21stcaveman (Hamid Maadani)]

In 84d5040b7739311e75879d3afb4c4e1f464469d1/macports-ports (master):

samba4: Fix linking issues
Closes: #61385