Opened 4 years ago

Last modified 16 months ago

#61529 new defect

moria @5.5.2_5: implicit declaration of functions

Reported by: mtetcs Owned by:
Priority: Normal Milestone:
Component: ports Version: 2.6.4
Keywords: catalina bigsur monterey ventura Cc: ryandesign (Ryan Carsten Schmidt), avstoddard (Control)
Port: moria


At first glance, it looks as if the compiler errors are a product of certain standard header files not being loaded.

Attachments (1)

main.log (58.9 KB) - added by mtetcs 4 years ago.

Download all attachments as: .zip

Change History (8)

Changed 4 years ago by mtetcs

Attachment: main.log added


comment:1 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: catalina bigsur added

It's the usual implicit declaration of function error we see in Xcode 12. Software needs to include the headers for the functions it uses. Moria doesn't.

comment:2 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)

The homepage we have listed in the port for moria (apparently also called umoria) no longer exists.

It looks like a more current homepage from the same developer is and version 5.6 claims to be available there but the FTP server appears to be down. We could try to find this file elsewhere and update the port to 5.6 but since that version is from 2008 it may not fix these problems either.

I also see a fork (?) called gmoria at where version 5.7.2 was released in 2017, which due to being newer seems to me to have a much greater chance of building correctly on modern systems.

As a user of moria, do you have an opinion on how we should update the port? Is gmoria a suitable replacement for moria -- should we make this replacement in MacPorts or stick with the original (u)moria?

comment:3 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)

And now I find where version 5.7.13 was released just a few months ago. This seems to be the most current and active development of moria with a modern homepage and presence on GitHub, so maybe that's what we should be updating to.

comment:4 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign added

comment:5 Changed 4 years ago by mtetcs

The umoria version you found compiled without issues on Big Sur, and accepted an existing save file. The directional keys are different - but as you suggest, this might be the best bet for future usage.

I persuaded moria @5.5.2_5 to compile after including the headers and building manually; I can probably submit a patch once I've tidied it up if that helps.

comment:6 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)

Thanks for verifying that.

I would rather get the most current version of (u)moria into MacPorts than develop and maintain patches to outdated versions.

comment:7 Changed 16 months ago by ryandesign (Ryan Carsten Schmidt)

Cc: avstoddard added
Keywords: monterey ventura added
Summary: moria @5.5.2_5 fails to build on Big Surmoria @5.5.2_5: implicit declaration of functions

Has duplicate #67021.

Note: See TracTickets for help on using tickets.