Opened 3 years ago

Closed 3 years ago

#61739 closed defect (fixed)

mame: add variant 'debug'; soft link tools in /bin; add tools man pages; improve link time; reduce warnings; eliminate superfluous files; remove variant 'python36'

Reported by: mascguy (Christopher Nielsen) Owned by: mascguy (Christopher Nielsen)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: mame

Description (last modified by mascguy (Christopher Nielsen))

Presently, the 0.226 port of Mame has some cleanup opportunities:

  • Superfluous files are installed;
  • Python variants cover versions 3.6 through 3.9; remove support for 3.6;
  • Add a 'debug' variant;
  • Reduce compilation warnings;
  • Improve abysmally-slow link times: 10+ minutes for release build, up to 60 minutes for debug! (Linker option -no_deduplicate to the rescue.)

And improve the Mame tools:

  • Create soft links in ${prefix}/bin;
  • Prefix executable names with 'mame-', to avoid clashes with system components;
  • Install man pages.

These issue will be fixed when the Mame project releases 0.227, or sooner if said release is delayed beyond December 2020.

Change History (21)

comment:1 Changed 3 years ago by mascguy (Christopher Nielsen)

Priority: LowNormal

comment:2 Changed 3 years ago by mascguy (Christopher Nielsen)

Description: modified (diff)
Summary: mame: small number of extraneous files included in port version 0.226mame: internal port cleanup: small number of extraneous files included; remove older python variants

comment:3 Changed 3 years ago by mascguy (Christopher Nielsen)

Description: modified (diff)

comment:4 Changed 3 years ago by mascguy (Christopher Nielsen)

Summary: mame: internal port cleanup: small number of extraneous files included; remove older python variantsmame: portfile cleanup: small number of extraneous files included; remove older python variants

comment:5 Changed 3 years ago by mascguy (Christopher Nielsen)

Description: modified (diff)

comment:6 Changed 3 years ago by mascguy (Christopher Nielsen)

Description: modified (diff)

comment:7 Changed 3 years ago by mascguy (Christopher Nielsen)

Description: modified (diff)

comment:8 Changed 3 years ago by mascguy (Christopher Nielsen)

Description: modified (diff)

comment:9 Changed 3 years ago by kencu (Ken)

why disable 32bit build support? keep it all going if possible... mame builds and runs on 10.5 PowerPC last I tried. One day it might not, but if it still does, no need to throw that away I say...

comment:10 in reply to:  9 Changed 3 years ago by mascguy (Christopher Nielsen)

Replying to kencu:

why disable 32bit build support? keep it all going if possible... mame builds and runs on 10.5 PowerPC last I tried. One day it might not, but if it still does, no need to throw that away I say...

The problem is that 32-bit x86 builds fail, due to compilation errors. And since it relates to the OpenGL headers, I suspect it might fail for 32-bit PPC too.

Of note, the last attempted buildbot job for PPC was last year, and it failed due to a dependency issue.

If you're interested in running a PPC build locally, I'd appreciate it! And if it succeeds, I'll happily keep 32-bit support for that architecture.

Your thoughts?

comment:11 Changed 3 years ago by mascguy (Christopher Nielsen)

Just remembered that I still have an old PowerBook G4, running MacOS 10.5, which could be used for testing PPC 32-bit.

So if you think keeping PPC support makes sense, I'm happy to try building and running there. Let me know Ken!

Last edited 3 years ago by mascguy (Christopher Nielsen) (previous) (diff)

comment:12 Changed 3 years ago by kencu (Ken)

So in these circumstances, don't purposefully break/disable/remove/delete the 32bit build. mame built fine for me on 10.5 PPC last time I did it. Many people might come along and do the fix, if you don't/won't/can't. But if you strip everything out for no reason, it is that much harder to do.

Now it's different if there is something about the 32bit build, say, that is a deal-breaker for the 64bit bit build. If it comes down to one or other other, not both -- OK then, sacrifice the lesser. But here I don't sense that.

BTW -- totally ignore the 10.5 PPC buildbot -- it hasn't been working for nearly 2 years, so anything it might say is bogus confusion.

comment:13 in reply to:  12 Changed 3 years ago by mascguy (Christopher Nielsen)

Replying to kencu:

So in these circumstances, don't purposefully break/disable/remove/delete the 32bit build. mame built fine for me on 10.5 PPC last time I did it. Many people might come along and do the fix, if you don't/won't/can't. But if you strip everything out for no reason, it is that much harder to do.

Absolutely Ken! The plan was to maintain all logic related to 32 vs. 64 bit in the portfile regardless. The only thing that was going to change, was supported_archs.

Now that we've chatted, I'll keep that list set to ppc ppc64 i386 x86_64. (Arm64 support is pending, and tracked by issue:61795.)

How does that sound?

comment:14 Changed 3 years ago by mascguy (Christopher Nielsen)

Description: modified (diff)

comment:15 Changed 3 years ago by mascguy (Christopher Nielsen)

Description: modified (diff)

comment:16 Changed 3 years ago by mascguy (Christopher Nielsen)

Description: modified (diff)

comment:17 Changed 3 years ago by mascguy (Christopher Nielsen)

Description: modified (diff)
Summary: mame: portfile cleanup: small number of extraneous files included; remove older python variantsmame: add variant 'debug'; soft link tools in /bin; add tools man pages; improve link time; reduce warnings; eliminate superfluous files; remove variant 'python36'

comment:18 Changed 3 years ago by mascguy (Christopher Nielsen)

comment:19 Changed 3 years ago by mascguy (Christopher Nielsen)

Pull request approved and merged. This ticket can be closed.

comment:20 Changed 3 years ago by mascguy (Christopher Nielsen)

This ticket can be closed.

comment:21 Changed 3 years ago by Christopher Nielsen <mascguy@…>

Resolution: fixed
Status: assignedclosed

In f5b8447521ffa1e79de726a6f904b4955618bac5/macports-ports (master):

mame: fix for macOS 10.13 builds; portfile cleanup

Fixes: #62049
Fixes: #61739

Note: See TracTickets for help on using tickets.