Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#61837 closed defect (fixed)

djvulibre: dependency librsvg is not needed

Reported by: Dave-Allured (Dave Allured) Owned by: NicosPavlov
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: Dave-Allured (Dave Allured)
Port: djvulibre

Description (last modified by Dave-Allured (Dave Allured))

Portfile includes both of these:

depends_build    port:librsvg
configure.args   --disable-desktopfiles

With --disable-desktopfiles, librsvg is never used in any build or link phase.

Please confirm this and remove the librsvg dependency. This is a heavy load because it requires rust etc. I tested locally and found that djvulibre builds fine without this dependency.

Change History (6)

comment:1 Changed 3 years ago by Dave-Allured (Dave Allured)

Cc: Dave-Allured added

comment:2 Changed 3 years ago by Dave-Allured (Dave Allured)

Description: modified (diff)

comment:3 Changed 3 years ago by NicosPavlov

Sorry for not answering sooner, I somehow did not see any notification from this ticket.

First, I am not absolutely sure that librsvg is never used with --disable-dektopfiles. Even with this option, the configure stage still searches for the conversion tool. This is most likely an overlook of the developers, but there might be a use of the conversion tool that I am missing.

Second, in the event that it is not needed, just removing the requirement is not enough, as it would not prevent opportunistic linking. Djvulibre even searches for librsvg, Inkscape, and ImageMagick, in that order.

comment:4 Changed 3 years ago by NicosPavlov

I could not see other use of librsvg, so it seems reasonable to remove the dependency.

comment:5 Changed 3 years ago by Nicolas Pavillon <pavillon.nicolas@…>

Resolution: fixed
Status: assignedclosed

In 98ee0763e34da833eeac9a05d4036e853fddcbd4/macports-ports (master):

djvulibre: remove unused dependency, avoid opportunistic linking (fixes #61837)

comment:6 Changed 3 years ago by Dave-Allured (Dave Allured)

That was my conclusion too, although I never finished proving it. Thanks for investigating and making [a complete pull request].

Edit: That is, committing a complete set of fixes. There was no PR.

Last edited 3 years ago by Dave-Allured (Dave Allured) (previous) (diff)
Note: See TracTickets for help on using tickets.