qt5-qtwebkit: build fails

[rhstanton]

Running MacOS Catalina and XCode 12.3, when I try to install qt5-qtwebkit, it fails to install. Here's the last section of the log file:

:info:build make[2]: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_aqua_qt5/qt5-qtwebkit/work/qtwebkit-opensource-src-5.9.2/Source/WebCore'
:info:build bison -d -p xpathyy xml/XPathGrammar.y -o generated/XPathGrammar.tab.c && mv -f generated/XPathGrammar.tab.c generated/XPathGrammar.cpp && mv -f generated/XPathGrammar.tab.h generated/XPathGrammar.h
:info:build perl /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_aqua_qt5/qt5-qtwebkit/work/qtwebkit-opensource-src-5.9.2/Source/WebKit2/Scripts/generate-forwarding-headers.pl /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_aqua_qt5/qt5-qtwebkit/work/qtwebkit-opensource-src-5.9.2/Source/WebCore /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_aqua_qt5/qt5-qtwebkit/work/qtwebkit-opensource-src-5.9.2/Source/include mac
:info:build xml/XPathGrammar.y:56.9-26: syntax error, unexpected identifier, expecting string
:info:build make[2]: *** [generated/XPathGrammar.cpp] Error 1
:info:build make[2]: *** Waiting for unfinished jobs....
:info:build make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_aqua_qt5/qt5-qtwebkit/work/qtwebkit-opensource-src-5.9.2/Source/WebCore'
:info:build make[1]: *** [sub-DerivedSources-pri-make_first-ordered] Error 2
:info:build make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_aqua_qt5/qt5-qtwebkit/work/qtwebkit-opensource-src-5.9.2/Source/WebCore'
:info:build make: *** [sub-Source-WebCore-WebCore-pro-make_first-ordered] Error 2
:info:build make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_aqua_qt5/qt5-qtwebkit/work/qtwebkit-opensource-src-5.9.2'
:info:build Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_aqua_qt5/qt5-qtwebkit/work/qtwebkit-opensource-src-5.9.2" && /usr/bin/make -j12 -w 
:info:build Exit code: 2
:error:build Failed to build qt5-qtwebkit: command execution failed
:debug:build Error code: CHILDSTATUS 76722 2
:debug:build Backtrace: command execution failed
:debug:build     while executing
:debug:build "system {*}$notty {*}$nice $fullcmdstring"
:debug:build     invoked from within
:debug:build "command_exec build"
:debug:build     (procedure "portbuild::build_main" line 8)
:debug:build     invoked from within
:debug:build "$procedure $targetname"
:error:build See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_aqua_qt5/qt5-qtwebkit/main.log for details.

[jhoyt4]

Can you post the full log? I suspect there may be more issues beforehand.

I have to comment out the following patches in the Portfile to get it working for me on Big Sur/Catalina with Xcode >=12.2

                #patchfiles-append patch-webkit_XPathGrammar.y.diff
                #patchfiles-append patch-webkit_makegrammar.pl.diff

[ryandesign (Ryan Carsten Schmidt)]

Which bison are you using: the one from MacPorts or the one from macOS? (Do you have the bison port installed?) Does using the other one change/fix the problem?

[kencu (Ken)]

as per the PR where I last commented, some do see this, but I just rebuilt it last night on Catalina with no changes and it built thru again for me without touching anything...I'll see if I have bison installed on that system.

I have been trying to get the Catalina buildbot to get to building it, but it's very busy

[rhstanton]

Full log file

[rhstanton]

I just attached the full log (zipped, as it was too long otherwise).

[kencu (Ken)]

I do have both bison and flex installed via MacPorts, and looking at my successful build log on Catalina, these are likely being used over any system versions:

make[2]: Entering directory `/opt/local/var/macports/build/_opt_macportsofficial_macports-ports_aqua_qt5/qt5-qtwebkit/work/qtwebkit-opensource-src-5.9.2/Source/ThirdParty/ANGLE'
flex --noline --nounistd --outfile=generated/glslang_lex.cpp src/compiler/glslang.l
flex --noline --nounistd --outfile=generated/Tokenizer_lex.cpp src/compiler/preprocessor/Tokenizer.l
bison --no-lines --skeleton=yacc.c --defines=generated/glslang_tab.h --output=generated/glslang_tab.cpp src/compiler/glslang.y
bison --no-lines --skeleton=yacc.c --defines=generated/ExpressionParser_tab.h --output=generated/ExpressionParser_tab.cpp src/compiler/preprocessor/ExpressionParser.y
src/compiler/preprocessor/ExpressionParser.y:65.1-12: src/compiler/glslang.ywarning::47 deprecated directive: ‘%pure-parser’, use ‘%

so try installing bison and flex, and if your build succeeds the most benign thing to do would be to add bison and maybe flex as build deps if they aren't already in there somehow.

[rhstanton]

I just install Macports bison and flex, and the installation now completes fine.

[kencu (Ken)]

yeah, so that's it. I don't know exactly at this moment why those patches were added in the first place -- will look -- but easiest thing is to add a build dep on bison. flex is probably not the culprit here. -- thanks to Ryan for guessing it.

[ken-cunningham-webuse]

In 4d1898c6a395740a4eaa748e264063a5ad354d29/macports-ports (master):

qt5-qtwebkit: add build dep on bison

closes: #61850

[chrstphrchvz (Christopher Chavez)]

In af24cab4f9c100fe3d26a3bf8ae905c58c49ed02/macports-ports (master):

qt511-qtwebkit: add build dep on bison

See: #61850

[skip ci]